2008-02-13 21:35:14

by Adrian Bunk

Subject: [2.6 patch] x86: don't make swapper_pg_fixmap global

It's not required for swapper_pg_fixmap to be global.

Signed-off-by: Adrian Bunk <[email protected]>

---
cdaa89e8d9f49eecc6ec9052db1d65a62f1be04b diff --git a/arch/x86/kernel/head_32.S b/arch/x86/kernel/head_32.S
index 74ef4a4..25eb985 100644
--- a/arch/x86/kernel/head_32.S
+++ b/arch/x86/kernel/head_32.S
@@ -612,7 +612,7 @@ ENTRY(swapper_pg_pmd)
ENTRY(swapper_pg_dir)
.fill 1024,4,0
#endif
-ENTRY(swapper_pg_fixmap)
+swapper_pg_fixmap:
.fill 1024,4,0
ENTRY(empty_zero_page)
.fill 4096,1,0

2008-02-13 21:56:41

by Ian Campbell

Subject: Re: [2.6 patch] x86: don't make swapper_pg_fixmap global

On Wed, 2008-02-13 at 23:29 +0200, Adrian Bunk wrote:
> It's not required for swapper_pg_fixmap to be global.
>
> Signed-off-by: Adrian Bunk <[email protected]>

Acked-by: Ian Campbell <[email protected]>

>
> ---
> cdaa89e8d9f49eecc6ec9052db1d65a62f1be04b diff --git a/arch/x86/kernel/head_32.S b/arch/x86/kernel/head_32.S
> index 74ef4a4..25eb985 100644
> --- a/arch/x86/kernel/head_32.S
> +++ b/arch/x86/kernel/head_32.S
> @@ -612,7 +612,7 @@ ENTRY(swapper_pg_pmd)
> ENTRY(swapper_pg_dir)
> .fill 1024,4,0
> #endif
> -ENTRY(swapper_pg_fixmap)
> +swapper_pg_fixmap:
> .fill 1024,4,0
> ENTRY(empty_zero_page)
> .fill 4096,1,0
>
--
Ian Campbell

Getting into trouble is easy.
-- D. Winkel and F. Prosser

2008-02-16 18:25:32

by Thomas Gleixner

Subject: Re: [2.6 patch] x86: don't make swapper_pg_fixmap global

On Wed, 13 Feb 2008, Adrian Bunk wrote:
> It's not required for swapper_pg_fixmap to be global.
>
> Signed-off-by: Adrian Bunk <[email protected]>

Applied. Thanks,

tglx