2008-03-14 01:48:17

by Robert P. J. Day

Subject: [PATCH] X86: Explicitly include required header files.

After an experimental cleanup of <linux/percpu.h>, these files were
exposed as invoking kmalloc() without including <linux/slab.h>.

Signed-off-by: Robert P. J. Day <[email protected]>

---

arch/x86/kernel/nmi_32.c | 1 +
arch/x86/kernel/test_nx.c | 2 ++
2 files changed, 3 insertions(+)

diff --git a/arch/x86/kernel/nmi_32.c b/arch/x86/kernel/nmi_32.c
index 6a0aa70..800b07d 100644
--- a/arch/x86/kernel/nmi_32.c
+++ b/arch/x86/kernel/nmi_32.c
@@ -22,6 +22,7 @@
#include <linux/cpumask.h>
#include <linux/kernel_stat.h>
#include <linux/kdebug.h>
+#include <linux/slab.h>

#include <asm/smp.h>
#include <asm/nmi.h>
diff --git a/arch/x86/kernel/test_nx.c b/arch/x86/kernel/test_nx.c
index 10b8a6f..787a5e4 100644
--- a/arch/x86/kernel/test_nx.c
+++ b/arch/x86/kernel/test_nx.c
@@ -11,6 +11,8 @@
*/
#include <linux/module.h>
#include <linux/sort.h>
+#include <linux/slab.h>
+
#include <asm/uaccess.h>
#include <asm/asm.h>


========================================================================
Robert P. J. Day Linux Consulting, Training and Annoying Kernel
Pedantry:
Signed-off-by: Robert P. J. Day <[email protected]
Have classroom, will lecture.

http://crashcourse.ca Waterloo, Ontario, CANADA
========================================================================

2008-03-21 11:28:46

by Ingo Molnar

Subject: Re: [PATCH] X86: Explicitly include required header files.

* Robert P. J. Day <[email protected]> wrote:

> After an experimental cleanup of <linux/percpu.h>, these files were
> exposed as invoking kmalloc() without including <linux/slab.h>.

thanks, applied.

Ingo