2008-03-15 09:02:40

by Robert P. J. Day

[permalink] [raw]
Subject: [PATCH] Remove superfluous include of string.h from percpu.h.


There's nothing in percpu.h that requires an explicit inclusion of
string.h.

Signed-off-by: Robert P. J. Day <[email protected]>

---

after how hideously i embarrassed myself with that earlier exchange,
i am by god going to get a patch out of this. :-)

compile-tested on x86 after "make allyesconfig", so that deletion
did not appear to cause any breakage anywhere in the tree.

p.s. for the [PATCH] subject line, what kernel subsystem would be
used for things like the header files?

diff --git a/include/linux/percpu.h b/include/linux/percpu.h
index 1ac9697..d746a2a 100644
--- a/include/linux/percpu.h
+++ b/include/linux/percpu.h
@@ -4,7 +4,6 @@
#include <linux/preempt.h>
#include <linux/slab.h> /* For kmalloc() */
#include <linux/smp.h>
-#include <linux/string.h> /* For memset() */
#include <linux/cpumask.h>

#include <asm/percpu.h>



========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
Have classroom, will lecture.

http://crashcourse.ca Waterloo, Ontario, CANADA
========================================================================