2008-07-07 19:19:12

by Robert P. J. Day

[permalink] [raw]
Subject: [PATCH] FS: Label tmpfs Kconfig option with "tmpfs".


Make it clear that the Kconfig option refers to "tmpfs".

Signed-off-by: Robert P. J. Day <[email protected]>

---

if people haven't yet figured out that this used to be shm fs, they
probably don't need to know.


diff --git a/fs/Kconfig b/fs/Kconfig
index 2694648..9360b69 100644
--- a/fs/Kconfig
+++ b/fs/Kconfig
@@ -979,7 +979,7 @@ config SYSFS
Designers of embedded systems may wish to say N here to conserve space.

config TMPFS
- bool "Virtual memory file system support (former shm fs)"
+ bool "tmpfs support (Virtual memory file system)"
help
Tmpfs is a file system which keeps all files in virtual memory.

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
Have classroom, will lecture.

http://crashcourse.ca Waterloo, Ontario, CANADA
========================================================================


2008-07-07 21:41:36

by Hugh Dickins

[permalink] [raw]
Subject: Re: [PATCH] FS: Label tmpfs Kconfig option with "tmpfs".

On Mon, 7 Jul 2008, Robert P. J. Day wrote:
>
> Make it clear that the Kconfig option refers to "tmpfs".
>
> Signed-off-by: Robert P. J. Day <[email protected]>

It's so long since I used anything but "make oldconfig", which
already shows TMPFS, making your mod seem redundant. But you're right,
menuconfig and xconfig don't show it, so your change is a good one.

Though for the moment I can only give you
acked-by: hugh dickins <[email protected]>:
the next entry is for "Tmpfs POSIX Access Control Lists"
so I'd rather you say "Tmpfs support (virtual memory file system)",
then you can uppercase my ack.

hugh

>
> ---
>
> if people haven't yet figured out that this used to be shm fs, they
> probably don't need to know.
>
>
> diff --git a/fs/Kconfig b/fs/Kconfig
> index 2694648..9360b69 100644
> --- a/fs/Kconfig
> +++ b/fs/Kconfig
> @@ -979,7 +979,7 @@ config SYSFS
> Designers of embedded systems may wish to say N here to conserve space.
>
> config TMPFS
> - bool "Virtual memory file system support (former shm fs)"
> + bool "tmpfs support (Virtual memory file system)"
> help
> Tmpfs is a file system which keeps all files in virtual memory.
>

2008-07-07 22:48:18

by Robert P. J. Day

[permalink] [raw]
Subject: Re: [PATCH] FS: Label tmpfs Kconfig option with "tmpfs".

On Mon, 7 Jul 2008, Hugh Dickins wrote:

> On Mon, 7 Jul 2008, Robert P. J. Day wrote:
> >
> > Make it clear that the Kconfig option refers to "tmpfs".
> >
> > Signed-off-by: Robert P. J. Day <[email protected]>
>
> It's so long since I used anything but "make oldconfig", which
> already shows TMPFS, making your mod seem redundant. But you're right,
> menuconfig and xconfig don't show it, so your change is a good one.
>
> Though for the moment I can only give you
> acked-by: hugh dickins <[email protected]>:
> the next entry is for "Tmpfs POSIX Access Control Lists"
> so I'd rather you say "Tmpfs support (virtual memory file system)",
> then you can uppercase my ack.

or i could change the next line to read "tmpfs" rather than "Tmpfs".
:-) does anyone have any strong feelings either way?

rday
--


========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
Have classroom, will lecture.

http://crashcourse.ca Waterloo, Ontario, CANADA
========================================================================