2008-08-03 21:40:43

by Robert P. J. Day

Subject: full list of unused CONFIGs under drivers/

amazingly, the full list of unused CONFIG variables under drivers/
now fits on a single page. whoo hoo. apparently, incessant nagging
gets results. :-)

===== FB_N411
drivers/video/Kconfig:708:config FB_N411
===== MTD_NAND_ATMEL_ECC_SOFT
drivers/mtd/nand/Kconfig:313:config MTD_NAND_ATMEL_ECC_SOFT
===== SCSI_QLOGIC_FC_FIRMWARE
drivers/scsi/Kconfig:1328:config SCSI_QLOGIC_FC_FIRMWARE
===== SERIAL_CPM_SCC1
drivers/serial/Kconfig:1138:config SERIAL_CPM_SCC1
===== SERIAL_CPM_SCC2
drivers/serial/Kconfig:1144:config SERIAL_CPM_SCC2
===== SERIAL_CPM_SCC3
drivers/serial/Kconfig:1150:config SERIAL_CPM_SCC3
===== SERIAL_CPM_SCC4
drivers/serial/Kconfig:1156:config SERIAL_CPM_SCC4
===== SERIAL_CPM_SMC1
drivers/serial/Kconfig:1162:config SERIAL_CPM_SMC1
===== SERIAL_CPM_SMC2
drivers/serial/Kconfig:1168:config SERIAL_CPM_SMC2
===== USB_OHCI_HCD_PCI
drivers/usb/host/Kconfig:186:config USB_OHCI_HCD_PCI

rday
--

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
Have classroom, will lecture.

http://crashcourse.ca Waterloo, Ontario, CANADA
========================================================================

2008-08-04 13:27:33

by Kumar Gala

Subject: Re: full list of unused CONFIGs under drivers/

On Aug 3, 2008, at 4:38 PM, Robert P. J. Day wrote:

> ===== SERIAL_CPM_SCC1
> drivers/serial/Kconfig:1138:config SERIAL_CPM_SCC1
> ===== SERIAL_CPM_SCC2
> drivers/serial/Kconfig:1144:config SERIAL_CPM_SCC2
> ===== SERIAL_CPM_SCC3
> drivers/serial/Kconfig:1150:config SERIAL_CPM_SCC3
> ===== SERIAL_CPM_SCC4
> drivers/serial/Kconfig:1156:config SERIAL_CPM_SCC4
> ===== SERIAL_CPM_SMC1
> drivers/serial/Kconfig:1162:config SERIAL_CPM_SMC1
> ===== SERIAL_CPM_SMC2
> drivers/serial/Kconfig:1168:config SERIAL_CPM_SMC2

I'll take care of these.

thanks

- k

2008-08-05 13:26:26

by Haavard Skinnemoen

Subject: Re: full list of unused CONFIGs under drivers/

"Robert P. J. Day" <[email protected]> wrote:
> ===== MTD_NAND_ATMEL_ECC_SOFT
> drivers/mtd/nand/Kconfig:313:config MTD_NAND_ATMEL_ECC_SOFT

It may be unreferenced, but it behaves as expected. It's part of a set
of three mutually exclusive choices, so after checking for the two
others, there's no point checking for the last one.

Of course, we could apply the patch below ;-)

Haavard

diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
index 3387e0d..d5775a9 100644
--- a/drivers/mtd/nand/atmel_nand.c
+++ b/drivers/mtd/nand/atmel_nand.c
@@ -47,6 +47,10 @@
#define no_ecc 0
#endif

+#ifdef CONFIG_MTD_NAND_ATMEL_ECC_SOFT
+/* Avoid incessant nagging */
+#endif
+
/* Register access macros */
#define ecc_readl(add, reg) \
__raw_readl(add + ATMEL_ECC_##reg)

2008-08-05 13:30:54

by Robert P. J. Day

Subject: Re: full list of unused CONFIGs under drivers/

On Tue, 5 Aug 2008, Haavard Skinnemoen wrote:

> "Robert P. J. Day" <[email protected]> wrote:
> > ===== MTD_NAND_ATMEL_ECC_SOFT
> > drivers/mtd/nand/Kconfig:313:config MTD_NAND_ATMEL_ECC_SOFT
>
> It may be unreferenced, but it behaves as expected. It's part of a set
> of three mutually exclusive choices, so after checking for the two
> others, there's no point checking for the last one.
>
> Of course, we could apply the patch below ;-)

no, that's ok, i do get the occasional false positives in the list.
still tweaking those scripts. :-)

rday
--

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
Have classroom, will lecture.

http://crashcourse.ca Waterloo, Ontario, CANADA
========================================================================