2009-01-02 15:05:13

by Robert P. J. Day

[permalink] [raw]
Subject: worth submitting a detailed EDID structure?


just noticed the header file include/video/edid.h, which defines
video EDID info as simply:

struct edid_info {
unsigned char dummy[128];
};

a couple months back, i had to mess with EDID info and defined a
detailed structure to manipulate EDID fields. is it worth submitting
that as a patch and union'ing that with the above? not a big deal for
me either way.

rday
--


========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
Have classroom, will lecture.

http://crashcourse.ca Waterloo, Ontario, CANADA
========================================================================


2009-01-02 22:56:19

by Eric Anholt

[permalink] [raw]
Subject: Re: worth submitting a detailed EDID structure?

On Fri, 2009-01-02 at 09:08 -0500, Robert P. J. Day wrote:
> just noticed the header file include/video/edid.h, which defines
> video EDID info as simply:
>
> struct edid_info {
> unsigned char dummy[128];
> };
>
> a couple months back, i had to mess with EDID info and defined a
> detailed structure to manipulate EDID fields. is it worth submitting
> that as a patch and union'ing that with the above? not a big deal for
> me either way.

The KMS code already has detailed EDID structures in drm_edid.h, for
what it's worth. We still need to get CEA extension bits ported over,
though.

--
Eric Anholt
[email protected] [email protected]



Attachments:
signature.asc (197.00 B)
This is a digitally signed message part

2009-01-03 09:22:34

by Robert P. J. Day

[permalink] [raw]
Subject: Re: worth submitting a detailed EDID structure?

On Fri, 2 Jan 2009, Eric Anholt wrote:

> On Fri, 2009-01-02 at 09:08 -0500, Robert P. J. Day wrote:
> > just noticed the header file include/video/edid.h, which defines
> > video EDID info as simply:
> >
> > struct edid_info {
> > unsigned char dummy[128];
> > };
> >
> > a couple months back, i had to mess with EDID info and defined a
> > detailed structure to manipulate EDID fields. is it worth
> > submitting that as a patch and union'ing that with the above?
> > not a big deal for me either way.
>
> The KMS code already has detailed EDID structures in drm_edid.h, for
> what it's worth. We still need to get CEA extension bits ported
> over, though.

ah, i hadn't noticed that. eggcellent, thanks.

rday
--

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
Have classroom, will lecture.

http://crashcourse.ca Waterloo, Ontario, CANADA
========================================================================