lib/Kconfig.debug: select PRINTK_DEBUG
should that perhaps refer to "DYNAMIC_PRINTK_DEBUG"? since there is
no such thing as a PRINTK_DEBUG Kconfig variable.
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Annoying Kernel Pedantry.
Web page: http://crashcourse.ca
Linked In: http://www.linkedin.com/in/rpjday
Twitter: http://twitter.com/rpjday
========================================================================
Robert P. J. Day wrote:
> lib/Kconfig.debug: select PRINTK_DEBUG
>
> should that perhaps refer to "DYNAMIC_PRINTK_DEBUG"? since there is
> no such thing as a PRINTK_DEBUG Kconfig variable.
Looks like a rudiment from an earlier version of Jason's "driver core:
basic infrastructure for per-module dynamic debug messages",
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=346e15beb5343c2eb8216d820f2ed8f150822b08
Search an LKML archive for '+#ifdef CONFIG_PRINTK_DEBUG'.
Jason, should it be deleted or replaced by something?
--
Stefan Richter
-=====-==--= -=-- =-=-=
http://arcgraph.de/sr/
On Tue, Apr 21, 2009 at 01:55:53PM +0200, Stefan Richter wrote:
> Robert P. J. Day wrote:
> > lib/Kconfig.debug: select PRINTK_DEBUG
> >
> > should that perhaps refer to "DYNAMIC_PRINTK_DEBUG"? since there is
> > no such thing as a PRINTK_DEBUG Kconfig variable.
>
> Looks like a rudiment from an earlier version of Jason's "driver core:
> basic infrastructure for per-module dynamic debug messages",
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=346e15beb5343c2eb8216d820f2ed8f150822b08
> Search an LKML archive for '+#ifdef CONFIG_PRINTK_DEBUG'.
>
> Jason, should it be deleted or replaced by something?
We re-named 'DYNAMIC_PRINTK_DEBUG' to 'DYNAMIC_DEBUG' in 2.6.30....
'PRINTK_DEBUG' as pointed out never existed. So, it appears to be
extraneous, and should be removed. thanks for pointing it out.
Signed-off-by: Jason Baron <[email protected]>
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index c6e854f..dd457af 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -891,7 +891,6 @@ config DYNAMIC_DEBUG
default n
depends on PRINTK
depends on DEBUG_FS
- select PRINTK_DEBUG
help
Compiles debug level messages into the kernel, which would not