2009-04-24 16:36:41

by Robert P. J. Day

[permalink] [raw]
Subject: [PATCH] Makefile: "make prepare" should be "make modules_prepare"


Correct the Makefile help text to read "make modules_prepare".

Signed-off-by: Robert P. J. Day <[email protected]>

---

i'm fairly sure that the correct target for configuring external
module builds is "modules_prepare," no?

diff --git a/Makefile b/Makefile
index 9e5dc8f..5a96549 100644
--- a/Makefile
+++ b/Makefile
@@ -1293,7 +1293,7 @@ help:
@echo ' dir/ - Build all files in dir and below'
@echo ' dir/file.[ois] - Build specified target only'
@echo ' dir/file.ko - Build module including final link'
- @echo ' prepare - Set up for building external modules'
+ @echo ' modules_prepare - Set up for building external modules'
@echo ' tags/TAGS - Generate tags file for editors'
@echo ' cscope - Generate cscope index'
@echo ' kernelrelease - Output the release version string'



========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Annoying Kernel Pedantry.

Web page: http://crashcourse.ca
Linked In: http://www.linkedin.com/in/rpjday
Twitter: http://twitter.com/rpjday
========================================================================


2009-04-25 07:26:21

by Sam Ravnborg

[permalink] [raw]
Subject: Re: [PATCH] Makefile: "make prepare" should be "make modules_prepare"

On Fri, Apr 24, 2009 at 12:35:23PM -0400, Robert P. J. Day wrote:
>
> Correct the Makefile help text to read "make modules_prepare".
>
> Signed-off-by: Robert P. J. Day <[email protected]>
>
> ---
>
> i'm fairly sure that the correct target for configuring external
> module builds is "modules_prepare," no?

Correct - applied.

Sam