2009-07-05 00:46:23

by Robert P. J. Day

Subject: [PATCH] SOUND: Remove commented out usage of dead MODULE_PARM().

Signed-off-by: Robert P. J. Day <[email protected]>

---

get rid of that commented usage of the now defunct MODULE_PARM macro
simply because it pollutes a scan for actual references to that dead
macro.

diff --git a/sound/oss/swarm_cs4297a.c b/sound/oss/swarm_cs4297a.c
index 1edab7b..3136c88 100644
--- a/sound/oss/swarm_cs4297a.c
+++ b/sound/oss/swarm_cs4297a.c
@@ -110,9 +110,6 @@ static void start_adc(struct cs4297a_state *s);
// rather than 64k as some of the games work more responsively.
// log base 2( buff sz = 32k).

-//static unsigned long defaultorder = 3;
-//MODULE_PARM(defaultorder, "i");
-
//
// Turn on/off debugging compilation by commenting out "#define CSDEBUG"
//
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Annoying Kernel Pedantry.

Web page: http://crashcourse.ca
Linked In: http://www.linkedin.com/in/rpjday
Twitter: http://twitter.com/rpjday
========================================================================

2009-07-07 07:59:50

by Jiri Kosina

Subject: Re: [PATCH] SOUND: Remove commented out usage of dead MODULE_PARM().

On Sat, 4 Jul 2009, Robert P. J. Day wrote:

>
> Signed-off-by: Robert P. J. Day <[email protected]>
>
> ---
>
> get rid of that commented usage of the now defunct MODULE_PARM macro
> simply because it pollutes a scan for actual references to that dead
> macro.
>
> diff --git a/sound/oss/swarm_cs4297a.c b/sound/oss/swarm_cs4297a.c
> index 1edab7b..3136c88 100644
> --- a/sound/oss/swarm_cs4297a.c
> +++ b/sound/oss/swarm_cs4297a.c
> @@ -110,9 +110,6 @@ static void start_adc(struct cs4297a_state *s);
> // rather than 64k as some of the games work more responsively.
> // log base 2( buff sz = 32k).
>
> -//static unsigned long defaultorder = 3;
> -//MODULE_PARM(defaultorder, "i");
> -
> //
> // Turn on/off debugging compilation by commenting out "#define CSDEBUG"
> //

Oh what a horrible driver anyway ...

Applied, thanks.

--
Jiri Kosina
SUSE Labs