since the merge window appears to be ready to close fairly soon(?),
i'm prepping to run my scanning scripts once again to identify (among
other things):
* unused Kconfig CONFIG variables
* references to CONFIG_ variables that don't even exist (both in
source files and Makefiles)
* references to non-existent header files
and bunches of other things. i'm open as to the best way to post the
results, since different people have different opinions.
and, no, i can't just submit patches since, in many cases, i have no
idea what the fix should be (if any) -- that's the kind of decision
best left to the respective subsystem maintainers.
thoughts? this is where i put the old output:
http://www.crashcourse.ca/wiki/index.php/Kernel_cleanup
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Annoying Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
========================================================================
Hello Robert,
On Sat, 2009-09-26 at 08:16 -0400, Robert P. J. Day wrote:
> since the merge window appears to be ready to close fairly soon(?),
> i'm prepping to run my scanning scripts once again to identify (among
> other things):
>
> * unused Kconfig CONFIG variables
> * references to CONFIG_ variables that don't even exist (both in
> source files and Makefiles)
> * references to non-existent header files
>
> and bunches of other things. i'm open as to the best way to post the
> results, since different people have different opinions.
>
> and, no, i can't just submit patches since, in many cases, i have no
> idea what the fix should be (if any) -- that's the kind of decision
> best left to the respective subsystem maintainers.
>
> thoughts? this is where i put the old output:
>
> http://www.crashcourse.ca/wiki/index.php/Kernel_cleanup
>
Thanks for reporting these results, I will try to fix them and submit
patches with Reported-by: Robert P. J. Day <[email protected]>
Thanks,
--
JSR
On Sat, 26 Sep 2009, Jaswinder Singh Rajput wrote:
> Hello Robert,
>
> On Sat, 2009-09-26 at 08:16 -0400, Robert P. J. Day wrote:
> > since the merge window appears to be ready to close fairly soon(?),
> > i'm prepping to run my scanning scripts once again to identify (among
> > other things):
> >
> > * unused Kconfig CONFIG variables
> > * references to CONFIG_ variables that don't even exist (both in
> > source files and Makefiles)
> > * references to non-existent header files
> >
> > and bunches of other things. i'm open as to the best way to post the
> > results, since different people have different opinions.
> >
> > and, no, i can't just submit patches since, in many cases, i have no
> > idea what the fix should be (if any) -- that's the kind of decision
> > best left to the respective subsystem maintainers.
> >
> > thoughts? this is where i put the old output:
> >
> > http://www.crashcourse.ca/wiki/index.php/Kernel_cleanup
> >
>
> Thanks for reporting these results, I will try to fix them and submit
> patches with Reported-by: Robert P. J. Day <[email protected]>
keep in mind that those are *old* results (although, of course, some
of it will still be relevant). i'll update those pages as soon as
-rc1 is out. unsurprisingly, some of that is historical cruft that's
been around a *looooong* time. very little of it represents actual
breakage but, occasionally, those scans will reveal actual typoes.
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Annoying Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
========================================================================
Hello Robert,
On Sat, 2009-09-26 at 08:44 -0400, Robert P. J. Day wrote:
> On Sat, 26 Sep 2009, Jaswinder Singh Rajput wrote:
>
> > Hello Robert,
> >
> > On Sat, 2009-09-26 at 08:16 -0400, Robert P. J. Day wrote:
> > > since the merge window appears to be ready to close fairly soon(?),
> > > i'm prepping to run my scanning scripts once again to identify (among
> > > other things):
> > >
> > > * unused Kconfig CONFIG variables
> > > * references to CONFIG_ variables that don't even exist (both in
> > > source files and Makefiles)
> > > * references to non-existent header files
> > >
> > > and bunches of other things. i'm open as to the best way to post the
> > > results, since different people have different opinions.
> > >
> > > and, no, i can't just submit patches since, in many cases, i have no
> > > idea what the fix should be (if any) -- that's the kind of decision
> > > best left to the respective subsystem maintainers.
> > >
> > > thoughts? this is where i put the old output:
> > >
> > > http://www.crashcourse.ca/wiki/index.php/Kernel_cleanup
> > >
> >
> > Thanks for reporting these results, I will try to fix them and submit
> > patches with Reported-by: Robert P. J. Day <[email protected]>
>
> keep in mind that those are *old* results (although, of course, some
> of it will still be relevant). i'll update those pages as soon as
> -rc1 is out. unsurprisingly, some of that is historical cruft that's
> been around a *looooong* time. very little of it represents actual
> breakage but, occasionally, those scans will reveal actual typoes.
>
For http://www.crashcourse.ca/wiki/index.php/Unused_CONFIG_variables :
I send following patches which looks relevant to me :
0001-alpha-Remove-unused-CONFIG-ALPHA_EV7.patch
0002-ARM-Remove-unused-CONFIG-ARCH_AT91SAM9260_SAM9XE.patch
0003-ARM-Remove-unused-CONFIG-reference-DEBUG_S3C_PORT.patch
0004-ARM-OMAP-Remove-unused-CONFIG-MACH_OMAP_HTCWIZARD.patch
0005-ARM-Remove-unused-CONFIG-SA1100_H3XXX.patch
0006-x86-SLUB-Remove-unused-CONFIG-FAST_CMPXCHG_LOCAL.patch
0007-xtensa-Remove-unused-CONFIG-XTENSA_ISS_NETWORK-and.patch
0008-isdn-Fix-HISAX_DE_AOC-it-should-be-CONFIG_DE_AOC.patch
For http://www.crashcourse.ca/wiki/index.php/Badref_CONFIG_variables
http://www.crashcourse.ca/wiki/index.php/Badref_make_CONFIG_variables
http://www.crashcourse.ca/wiki/index.php/Badref_linux_header_files
Enough information is not present because we need to make Kconfig
entries or so. So I request you to send these information to respective
maintainers so that they can fix it.
And if you provide these scripts to Sam (also Cc) then he will make some
option line 'make configcheck' so that other developers can also take
advantages of your scripts.
For http://www.crashcourse.ca/wiki/index.php/The_style_script :
I think Julia (also Cc) and some janitors (also Cc) are already working
on few points.
If you also provide these scripts to Sam, then we can also take
advantage of it.
Thanks,
--
JSR
Hi Robert,
On Sat, Sep 26, 2009 at 10:16 AM, Robert P. J. Day
<[email protected]> wrote:
>
> since the merge window appears to be ready to close fairly soon(?),
> i'm prepping to run my scanning scripts once again to identify (among
> other things):
> * unused Kconfig CONFIG variables
> * references to CONFIG_ variables that don't even exist (both in
> source files and Makefiles)
> * references to non-existent header files
I'm following your reports from:
http://www.crashcourse.ca/wiki/index.php/The_style_script, and I'm
fixing some of them.
I would ask you if you could make those scripts available. So I can
run them into the latest linux tree.
Thanks in advance for providing this reports.