2010-01-01 17:28:40

by Robert P. J. Day

[permalink] [raw]
Subject: [PATCH] HVSI: Fix apparently backwards args to time_before() in hvsi.c


Signed-off-by: Robert P. J. Day <[email protected]>

---

no appropriate subsystem maintainer listed in MAINTAINERS.

diff --git a/drivers/char/hvsi.c b/drivers/char/hvsi.c
index 793b236..71c0fcd 100644
--- a/drivers/char/hvsi.c
+++ b/drivers/char/hvsi.c
@@ -711,7 +711,7 @@ static void hvsi_drain_input(struct hvsi_struct *hp)
uint8_t buf[HVSI_MAX_READ] __ALIGNED__;
unsigned long end_jiffies = jiffies + HVSI_TIMEOUT;

- while (time_before(end_jiffies, jiffies))
+ while (time_before(jiffies, end_jiffies))
if (0 == hvsi_read(hp, buf, HVSI_MAX_READ))
break;
}

rday
--

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Kernel Pedantry.

Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
========================================================================


2010-01-01 21:11:47

by Benjamin Herrenschmidt

[permalink] [raw]
Subject: Re: [PATCH] HVSI: Fix apparently backwards args to time_before() in hvsi.c

On Fri, 2010-01-01 at 19:15 +0100, Bartlomiej Zolnierkiewicz wrote:
> On Friday 01 January 2010 06:28:03 pm Robert P. J. Day wrote:
> >
> > Signed-off-by: Robert P. J. Day <[email protected]>
> >
> > ---
> >
> > no appropriate subsystem maintainer listed in MAINTAINERS.
>
> drivers/char/Makefile:
> obj-$(CONFIG_HVC_CONSOLE) += hvc_vio.o hvsi.o
>
> so it should belong to:
>
> HYPERVISOR VIRTUAL CONSOLE DRIVER
> L: [email protected]
> S: Odd Fixes
> F: drivers/char/hvc_*
>
> [ Though maybe Ben would be willing to pick this one up directly
> as hvsi is PPC specific thingy and patch is obviously correct. ]

Sure, I'll pick that one up.

Cheers,
Ben.

> > diff --git a/drivers/char/hvsi.c b/drivers/char/hvsi.c
> > index 793b236..71c0fcd 100644
> > --- a/drivers/char/hvsi.c
> > +++ b/drivers/char/hvsi.c
> > @@ -711,7 +711,7 @@ static void hvsi_drain_input(struct hvsi_struct *hp)
> > uint8_t buf[HVSI_MAX_READ] __ALIGNED__;
> > unsigned long end_jiffies = jiffies + HVSI_TIMEOUT;
> >
> > - while (time_before(end_jiffies, jiffies))
> > + while (time_before(jiffies, end_jiffies))
> > if (0 == hvsi_read(hp, buf, HVSI_MAX_READ))
> > break;
> > }
>
> --
> Bartlomiej Zolnierkiewicz
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

Subject: Re: [PATCH] HVSI: Fix apparently backwards args to time_before() in hvsi.c

On Friday 01 January 2010 06:28:03 pm Robert P. J. Day wrote:
>
> Signed-off-by: Robert P. J. Day <[email protected]>
>
> ---
>
> no appropriate subsystem maintainer listed in MAINTAINERS.

drivers/char/Makefile:
obj-$(CONFIG_HVC_CONSOLE) += hvc_vio.o hvsi.o

so it should belong to:

HYPERVISOR VIRTUAL CONSOLE DRIVER
L: [email protected]
S: Odd Fixes
F: drivers/char/hvc_*

[ Though maybe Ben would be willing to pick this one up directly
as hvsi is PPC specific thingy and patch is obviously correct. ]

> diff --git a/drivers/char/hvsi.c b/drivers/char/hvsi.c
> index 793b236..71c0fcd 100644
> --- a/drivers/char/hvsi.c
> +++ b/drivers/char/hvsi.c
> @@ -711,7 +711,7 @@ static void hvsi_drain_input(struct hvsi_struct *hp)
> uint8_t buf[HVSI_MAX_READ] __ALIGNED__;
> unsigned long end_jiffies = jiffies + HVSI_TIMEOUT;
>
> - while (time_before(end_jiffies, jiffies))
> + while (time_before(jiffies, end_jiffies))
> if (0 == hvsi_read(hp, buf, HVSI_MAX_READ))
> break;
> }

--
Bartlomiej Zolnierkiewicz