2017-11-27 23:47:10

by James Morris

[permalink] [raw]
Subject: Re: [PATCH v5 next 0/5] Improve Module autoloading infrastructure

On Mon, 27 Nov 2017, Kees Cook wrote:

> > if (WARN_ON_ONCE(!capable(CAP_SYS_MODULE) ||
> > !capable(CAP_SYS_ADMIN) ||
> > !capable(CAP_NET_ADMIN) ||
> > !unprivileged_autoload(module_name)))

(Side note: the capable() calls would ideally come after the whitelist
check).

> We have some of this already with the module prefixes. Doing this
> per-module would need to be exported to userspace, I think. It'd be
> way too fragile sitting in the kernel.

What about writing a whitelist to /proc (per-task) or /sys/fs (global) ?

The per-task whitelist is inherited from the global one by default, or
from a parent process if it's been modified in the parent.


--
James Morris
<[email protected]>


From 1585262302854503054@xxx Mon Nov 27 23:05:42 +0000 2017
X-GM-THRID: 1585240558529359461
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread