Remove a tautology; since
commit 0bddd227f3dc ("Documentation: update for gcc 4.9 requirement")
which raised the minimally supported version of GCC to 4.9, this case is
always true.
Link: https://github.com/ClangBuiltLinux/linux/issues/427
Signed-off-by: Nick Desaulniers <[email protected]>
---
arch/mips/include/asm/compiler.h | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/arch/mips/include/asm/compiler.h b/arch/mips/include/asm/compiler.h
index a2cb2d2b1c07..2b06090a78b2 100644
--- a/arch/mips/include/asm/compiler.h
+++ b/arch/mips/include/asm/compiler.h
@@ -43,14 +43,7 @@
#undef barrier_before_unreachable
#define barrier_before_unreachable() asm volatile(".insn")
-#if !defined(CONFIG_CC_IS_GCC) || \
- (__GNUC__ > 4) || (__GNUC__ == 4 && __GNUC_MINOR__ >= 9)
-# define GCC_OFF_SMALL_ASM() "ZC"
-#elif defined(CONFIG_CPU_MICROMIPS)
-# error "microMIPS compilation unsupported with GCC older than 4.9"
-#else
-# define GCC_OFF_SMALL_ASM() "R"
-#endif
+#define GCC_OFF_SMALL_ASM() "ZC"
#ifdef CONFIG_CPU_MIPSR6
#define MIPS_ISA_LEVEL "mips64r6"
--
2.29.2.222.g5d2a92d10f8-goog
On Tue, Nov 10, 2020 at 07:21:05PM -0800, Nick Desaulniers wrote:
> Remove a tautology; since
> commit 0bddd227f3dc ("Documentation: update for gcc 4.9 requirement")
> which raised the minimally supported version of GCC to 4.9, this case is
> always true.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/427
> Signed-off-by: Nick Desaulniers <[email protected]>
> ---
> arch/mips/include/asm/compiler.h | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
On Thu, 12 Nov 2020, Thomas Bogendoerfer wrote:
> > Remove a tautology; since
> > commit 0bddd227f3dc ("Documentation: update for gcc 4.9 requirement")
> > which raised the minimally supported version of GCC to 4.9, this case is
> > always true.
> >
> > Link: https://github.com/ClangBuiltLinux/linux/issues/427
> > Signed-off-by: Nick Desaulniers <[email protected]>
> > ---
> > arch/mips/include/asm/compiler.h | 9 +--------
> > 1 file changed, 1 insertion(+), 8 deletions(-)
>
> applied to mips-next.
It probably makes sense to get rid of GCC_OFF_SMALL_ASM altogether, as
this syntactical indirection brings us nothing at this point and only
obfuscates sources.
Maciej
On Thu, Nov 12, 2020 at 4:19 PM Maciej W. Rozycki <[email protected]> wrote:
>
> On Thu, 12 Nov 2020, Thomas Bogendoerfer wrote:
>
> > > Remove a tautology; since
> > > commit 0bddd227f3dc ("Documentation: update for gcc 4.9 requirement")
> > > which raised the minimally supported version of GCC to 4.9, this case is
> > > always true.
> > >
> > > Link: https://github.com/ClangBuiltLinux/linux/issues/427
> > > Signed-off-by: Nick Desaulniers <[email protected]>
> > > ---
> > > arch/mips/include/asm/compiler.h | 9 +--------
> > > 1 file changed, 1 insertion(+), 8 deletions(-)
> >
> > applied to mips-next.
>
> It probably makes sense to get rid of GCC_OFF_SMALL_ASM altogether, as
> this syntactical indirection brings us nothing at this point and only
> obfuscates sources.
Sure, that sounds good. Send a patch!
--
Thanks,
~Nick Desaulniers
On Thu, 12 Nov 2020, Nick Desaulniers wrote:
> > It probably makes sense to get rid of GCC_OFF_SMALL_ASM altogether, as
> > this syntactical indirection brings us nothing at this point and only
> > obfuscates sources.
>
> Sure, that sounds good. Send a patch!
Well, I have felt satisfied enough with making the original patch, commit
b0984c43702f ("MIPS: Fix microMIPS LL/SC immediate offsets"), so I'll give
someone else the chance to take the pride of undoing it now, now that it's
not needed anymore.
Maciej