2010-11-07 22:41:24

by J. Neuschäfer

[permalink] [raw]
Subject: [PATCH] fix spelling in drivers/misc/Kconfig

--- drivers/misc/Kconfig.orig 2010-11-07 22:56:37.000000000 +0100
+++ drivers/misc/Kconfig 2010-11-07 23:00:00.000000000 +0100
@@ -402,7 +402,7 @@
DAC7512 16-bit digital-to-analog converter.

This driver can also be built as a module. If so, the module
- will be calles ti_dac7512.
+ will be called ti_dac7512.

config VMWARE_BALLOON
tristate "VMware Balloon Driver"


Attachments:
(No filename) (95.00 B)
drivers (384.00 B)
Download all attachments

2010-11-07 22:46:13

by Jesper Juhl

[permalink] [raw]
Subject: Re: [PATCH] fix spelling in drivers/misc/Kconfig

On Sun, 7 Nov 2010, Jonathan Neusch?fer wrote:

> Hello list.
>
> This patch should be trivial and obvious.
>
> Please CC me in replies.
>
> Jonathan
> ---
>

Hi Jonathan,

You should:

- add a Signed-off-by: line (see Documentation/SubmittingPatches).
- add output from 'diffstat' (again see Documentation/SubmittingPatches).
- include patches inline, not as attachments.
- add [email protected] to CC for trivial stuff such as this.


--
Jesper Juhl <[email protected]> http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.

2010-11-07 22:48:35

by Jesper Juhl

[permalink] [raw]
Subject: Re: [PATCH] fix spelling in drivers/misc/Kconfig

On Sun, 7 Nov 2010, Jesper Juhl wrote:

> On Sun, 7 Nov 2010, Jonathan Neusch?fer wrote:
>
> > Hello list.
> >
> > This patch should be trivial and obvious.
> >
> > Please CC me in replies.
> >
> > Jonathan
> > ---
> >
>
> Hi Jonathan,
>
> You should:
>
> - add a Signed-off-by: line (see Documentation/SubmittingPatches).
> - add output from 'diffstat' (again see Documentation/SubmittingPatches).
> - include patches inline, not as attachments.
> - add [email protected] to CC for trivial stuff such as this.
>

By the way, your patch looks fine, so feel free to add

Reviewed-by: Jesper Juhl <[email protected]>

after your own Signed-off-by: line when you re-submit the patch :-)


--
Jesper Juhl <[email protected]> http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.

2010-11-08 15:20:50

by J. Neuschäfer

[permalink] [raw]
Subject: Re: [PATCH] fix spelling in drivers/misc/Kconfig

On Sun, Nov 07, 2010 at 11:34:53PM +0100, Jesper Juhl wrote:
> You should:
>
> - add a Signed-off-by: line (see Documentation/SubmittingPatches).
> - add output from 'diffstat' (again see Documentation/SubmittingPatches).
> - include patches inline, not as attachments.
> - add [email protected] to CC for trivial stuff such as this.

Thanks for your advice.

Jonathan