2010-12-09 04:20:29

by Namhyung Kim

Subject: [PATCH] poll: fix a typo in comment

Signed-off-by: Namhyung Kim <[email protected]>
---
include/linux/poll.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/poll.h b/include/linux/poll.h
index 56e76af78102..afd3375e58ee 100644
--- a/include/linux/poll.h
+++ b/include/linux/poll.h
@@ -57,7 +57,7 @@ struct poll_table_entry {
};

/*
- * Structures and helpers for sys_poll/sys_poll
+ * Structures and helpers for sys_select/sys_poll
*/
struct poll_wqueues {
poll_table pt;
--
1.7.3.3.400.g93cef

2010-12-09 06:31:29

by KOSAKI Motohiro

Subject: Re: [PATCH] poll: fix a typo in comment

> Signed-off-by: Namhyung Kim <[email protected]>
> ---
> include/linux/poll.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/poll.h b/include/linux/poll.h
> index 56e76af78102..afd3375e58ee 100644
> --- a/include/linux/poll.h
> +++ b/include/linux/poll.h
> @@ -57,7 +57,7 @@ struct poll_table_entry {
> };
>
> /*
> - * Structures and helpers for sys_poll/sys_poll
> + * Structures and helpers for sys_select/sys_poll
> */

Now we don't have sys_poll() and sys_poll() function. At least they
are hidden by SYSCALL_DEFINEx() macro.

so probably, "for select/poll syscall" is better explanation?



> struct poll_wqueues {
> poll_table pt;
> --
> 1.7.3.3.400.g93cef
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

2010-12-09 06:49:02

by Namhyung Kim

Subject: Re: [PATCH] poll: fix a typo in comment

On Thu, Dec 9, 2010 at 15:31, KOSAKI Motohiro
<[email protected]> wrote:
>> Signed-off-by: Namhyung Kim <[email protected]>
>> ---
>> ?include/linux/poll.h | ? ?2 +-
>> ?1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/include/linux/poll.h b/include/linux/poll.h
>> index 56e76af78102..afd3375e58ee 100644
>> --- a/include/linux/poll.h
>> +++ b/include/linux/poll.h
>> @@ -57,7 +57,7 @@ struct poll_table_entry {
>> ?};
>>
>> ?/*
>> - * Structures and helpers for sys_poll/sys_poll
>> + * Structures and helpers for sys_select/sys_poll
>> ? */
>
> Now we don't have sys_poll() and sys_poll() function. At least they
> are hidden by SYSCALL_DEFINEx() macro.
>
> so probably, "for select/poll syscall" is better explanation?
>

Good point. Will resend.
Thanks.


--
Regards,
Namhyung Kim

2010-12-09 16:57:36

by Namhyung Kim

Subject: [PATCH UPDATED] poll: fix a typo in comment

Convert duplicated sys_poll to select. As Kosaki suggests, sys_poll() and
sys_select() are now hidden by SYSCALL_DEFINEx() macros so it would be
better to use plain select/poll syscall name.

Signed-off-by: Namhyung Kim <[email protected]>
---
include/linux/poll.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/poll.h b/include/linux/poll.h
index 56e76af78102..afd3375e58ee 100644
--- a/include/linux/poll.h
+++ b/include/linux/poll.h
@@ -57,7 +57,7 @@ struct poll_table_entry {
};

/*
- * Structures and helpers for sys_poll/sys_poll
+ * Structures and helpers for select/poll syscall
*/
struct poll_wqueues {
poll_table pt;
--
1.7.3.3.400.g93cef

2010-12-10 05:41:23

by KOSAKI Motohiro

Subject: Re: [PATCH UPDATED] poll: fix a typo in comment

> Convert duplicated sys_poll to select. As Kosaki suggests, sys_poll() and
> sys_select() are now hidden by SYSCALL_DEFINEx() macros so it would be
> better to use plain select/poll syscall name.
>
> Signed-off-by: Namhyung Kim <[email protected]>

Thank you.
Reviewed-by: KOSAKI Motohiro <[email protected]>

> ---
> include/linux/poll.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/poll.h b/include/linux/poll.h
> index 56e76af78102..afd3375e58ee 100644
> --- a/include/linux/poll.h
> +++ b/include/linux/poll.h
> @@ -57,7 +57,7 @@ struct poll_table_entry {
> };
>
> /*
> - * Structures and helpers for sys_poll/sys_poll
> + * Structures and helpers for select/poll syscall
> */
> struct poll_wqueues {
> poll_table pt;
> --
> 1.7.3.3.400.g93cef
>

2010-12-10 14:07:00

by Jiri Kosina

Subject: Re: [PATCH UPDATED] poll: fix a typo in comment

On Fri, 10 Dec 2010, KOSAKI Motohiro wrote:

> > Convert duplicated sys_poll to select. As Kosaki suggests, sys_poll() and
> > sys_select() are now hidden by SYSCALL_DEFINEx() macros so it would be
> > better to use plain select/poll syscall name.
> >
> > Signed-off-by: Namhyung Kim <[email protected]>
>
> Thank you.
> Reviewed-by: KOSAKI Motohiro <[email protected]>

Applied.

--
Jiri Kosina
SUSE Labs, Novell Inc.