2011-05-03 20:55:09

by Peter Foley

Subject: [PATCH resend] staging: hv: make HYPERV_UTILS depend on NLS to prevent a build error

When HYPERV_UTILS=y and NLS=n the build fails with this error:
MODPOST 3 modules
ERROR: "utf8s_to_utf16s" [drivers/staging/hv/hv_utils.ko] undefined!

This patch fixes this by adding a dependency on NLS to HYPERV_UTILS.

Signed-off-by: Peter Foley <[email protected]>
---
drivers/staging/hv/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/hv/Kconfig b/drivers/staging/hv/Kconfig
index d41f380..76f0756 100644
--- a/drivers/staging/hv/Kconfig
+++ b/drivers/staging/hv/Kconfig
@@ -31,7 +31,7 @@ config HYPERV_NET

config HYPERV_UTILS
tristate "Microsoft Hyper-V Utilities driver"
- depends on CONNECTOR
+ depends on CONNECTOR && NLS
default HYPERV
help
Select this option to enable the Hyper-V Utilities.
--
1.7.5.rc1

2011-05-03 21:01:41

by Greg KH

Subject: Re: [PATCH resend] staging: hv: make HYPERV_UTILS depend on NLS to prevent a build error

On Tue, May 03, 2011 at 04:53:54PM -0400, [email protected] wrote:
> When HYPERV_UTILS=y and NLS=n the build fails with this error:
> MODPOST 3 modules ERROR: "utf8s_to_utf16s"
> [drivers/staging/hv/hv_utils.ko] undefined!
>
> This patch fixes this by adding a dependency on NLS to HYPERV_UTILS.
>
> Signed-off-by: Peter Foley <[email protected]>
> ---
> drivers/staging/hv/Kconfig | 2 +-

Nope, still not working, please fix your email client, it is messing up
the patch. Read the file, Documentation/email_client.txt for hints on
how to do this.

thanks,

greg k-h