Remove duplicate linux/serial_8250.h include from
arch/arm/mach-dove/common.c that was introduced by commit
5c60255149eece2a36ec9f5c99817b85f96fe8ec .
Signed-off-by: Jesper Juhl <[email protected]>
---
common.c | 1 -
1 file changed, 1 deletion(-)
note: untested patch since I have no way to really build arm stuff.
patch is against Linus' tree.
diff --git a/arch/arm/mach-dove/common.c b/arch/arm/mach-dove/common.c
index 5ed51b8..b6c3d6b 100644
--- a/arch/arm/mach-dove/common.c
+++ b/arch/arm/mach-dove/common.c
@@ -17,7 +17,6 @@
#include <linux/clk.h>
#include <linux/mbus.h>
#include <linux/ata_platform.h>
-#include <linux/serial_8250.h>
#include <linux/gpio.h>
#include <asm/page.h>
#include <asm/setup.h>
--
Jesper Juhl <[email protected]> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
Jesper Juhl pointed out there is a redundant include of
linux/serial_8250.h. However it turns out both are redundant.
This patch removes them both.
Only compile tested.
Reported-by: Jesper Juhl <[email protected]>
Signed-off-by: Andrew Lunn <[email protected]>
---
arch/arm/mach-dove/common.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-dove/common.c b/arch/arm/mach-dove/common.c
index 5ed51b8..83dce85 100644
--- a/arch/arm/mach-dove/common.c
+++ b/arch/arm/mach-dove/common.c
@@ -13,11 +13,9 @@
#include <linux/init.h>
#include <linux/platform_device.h>
#include <linux/pci.h>
-#include <linux/serial_8250.h>
#include <linux/clk.h>
#include <linux/mbus.h>
#include <linux/ata_platform.h>
-#include <linux/serial_8250.h>
#include <linux/gpio.h>
#include <asm/page.h>
#include <asm/setup.h>
--
1.7.4.4
Hello.
Jesper Juhl wrote:
> Remove duplicate linux/serial_8250.h include from
> arch/arm/mach-dove/common.c that was introduced by commit
> 5c60255149eece2a36ec9f5c99817b85f96fe8ec .
Please also specify that commit's summary -- for the human readers.
> Signed-off-by: Jesper Juhl <[email protected]>
WBR, Sergei
On Thu, 26 May 2011, Andrew Lunn wrote:
> Jesper Juhl pointed out there is a redundant include of
> linux/serial_8250.h. However it turns out both are redundant.
> This patch removes them both.
>
> Only compile tested.
>
> Reported-by: Jesper Juhl <[email protected]>
> Signed-off-by: Andrew Lunn <[email protected]>
Seems you are right.
Reviewed-by: Jesper Juhl <[email protected]>
--
Jesper Juhl <[email protected]> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
On Thu, 16 Jun 2011, Jesper Juhl wrote:
> > Jesper Juhl pointed out there is a redundant include of
> > linux/serial_8250.h. However it turns out both are redundant.
> > This patch removes them both.
> >
> > Only compile tested.
> >
> > Reported-by: Jesper Juhl <[email protected]>
> > Signed-off-by: Andrew Lunn <[email protected]>
>
> Seems you are right.
>
> Reviewed-by: Jesper Juhl <[email protected]>
I don't seem to be able to find the patch anywhere during a quick search
of the archives. Could you please bounce it to me (in case it hasn't been
already applied elsewhere)?
Thanks,
--
Jiri Kosina
SUSE Labs
On Thu, 16 Jun 2011, Jesper Juhl wrote:
> On Thu, 26 May 2011, Andrew Lunn wrote:
>
> > Jesper Juhl pointed out there is a redundant include of
> > linux/serial_8250.h. However it turns out both are redundant.
> > This patch removes them both.
> >
> > Only compile tested.
> >
> > Reported-by: Jesper Juhl <[email protected]>
> > Signed-off-by: Andrew Lunn <[email protected]>
>
> Seems you are right.
>
> Reviewed-by: Jesper Juhl <[email protected]>
Doesn't seem to be in linux-next as of today. I have picked it up.
--
Jiri Kosina
SUSE Labs
On Thu, 16 Jun 2011, Jesper Juhl wrote:
> On Thu, 26 May 2011, Andrew Lunn wrote:
>
> > Jesper Juhl pointed out there is a redundant include of
> > linux/serial_8250.h. However it turns out both are redundant.
> > This patch removes them both.
> >
> > Only compile tested.
> >
> > Reported-by: Jesper Juhl <[email protected]>
> > Signed-off-by: Andrew Lunn <[email protected]>
>
> Seems you are right.
>
> Reviewed-by: Jesper Juhl <[email protected]>
Could this patch be sent to RMK's patch system if no one else
picks it up please?
Thanks.
Nicolas
On Sun, 19 Jun 2011, Nicolas Pitre wrote:
> > > Jesper Juhl pointed out there is a redundant include of
> > > linux/serial_8250.h. However it turns out both are redundant.
> > > This patch removes them both.
> > >
> > > Only compile tested.
> > >
> > > Reported-by: Jesper Juhl <[email protected]>
> > > Signed-off-by: Andrew Lunn <[email protected]>
> >
> > Seems you are right.
> >
> > Reviewed-by: Jesper Juhl <[email protected]>
>
> Could this patch be sent to RMK's patch system if no one else
> picks it up please?
I have picked it up last week.
--
Jiri Kosina
SUSE Labs