2015-02-06 16:36:49

by Josh Poimboeuf

Subject: [PATCH] livepatch: add missing newline to error message

Signed-off-by: Josh Poimboeuf <[email protected]>
---
kernel/livepatch/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
index 9adf86b..ff7f47d 100644
--- a/kernel/livepatch/core.c
+++ b/kernel/livepatch/core.c
@@ -211,7 +211,7 @@ static int klp_verify_vmlinux_symbol(const char *name, unsigned long addr)
if (kallsyms_on_each_symbol(klp_verify_callback, &args))
return 0;

- pr_err("symbol '%s' not found at specified address 0x%016lx, kernel mismatch?",
+ pr_err("symbol '%s' not found at specified address 0x%016lx, kernel mismatch?\n",
name, addr);
return -EINVAL;
}
--
2.1.0

2015-02-06 20:29:13

by Jiri Kosina

Subject: Re: [PATCH] livepatch: add missing newline to error message

On Fri, 6 Feb 2015, Josh Poimboeuf wrote:

> Signed-off-by: Josh Poimboeuf <[email protected]>
> ---
> kernel/livepatch/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
> index 9adf86b..ff7f47d 100644
> --- a/kernel/livepatch/core.c
> +++ b/kernel/livepatch/core.c
> @@ -211,7 +211,7 @@ static int klp_verify_vmlinux_symbol(const char *name, unsigned long addr)
> if (kallsyms_on_each_symbol(klp_verify_callback, &args))
> return 0;
>
> - pr_err("symbol '%s' not found at specified address 0x%016lx, kernel mismatch?",
> + pr_err("symbol '%s' not found at specified address 0x%016lx, kernel mismatch?\n",
> name, addr);
> return -EINVAL;

Applied, thanks Josh.

--
Jiri Kosina
SUSE Labs