2015-05-05 08:10:02

by Jiri Slaby

Subject: [PATCH 1/1] HID: prodikeys, remove unused variable

'key' is set but never used in the first loop. So remove the set.

And indent the re-set of pm->last_key properly.

Signed-off-by: Jiri Slaby <[email protected]>
---
drivers/hid/hid-prodikeys.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/hid/hid-prodikeys.c b/drivers/hid/hid-prodikeys.c
index 91fab975063c..e3e98ccf137b 100644
--- a/drivers/hid/hid-prodikeys.c
+++ b/drivers/hid/hid-prodikeys.c
@@ -395,11 +395,10 @@ static int pcmidi_handle_report4(struct pcmidi_snd *pm, u8 *data)

/* break keys */
for (bit_index = 0; bit_index < 24; bit_index++) {
- key = pm->last_key[bit_index];
if (!((0x01 << bit_index) & bit_mask)) {
input_event(pm->input_ep82, EV_KEY,
pm->last_key[bit_index], 0);
- pm->last_key[bit_index] = 0;
+ pm->last_key[bit_index] = 0;
}
}

--
2.3.5

2015-05-07 08:36:30

by Jiri Kosina

Subject: Re: [PATCH 1/1] HID: prodikeys, remove unused variable

On Tue, 5 May 2015, Jiri Slaby wrote:

> 'key' is set but never used in the first loop. So remove the set.
>
> And indent the re-set of pm->last_key properly.
>
> Signed-off-by: Jiri Slaby <[email protected]>

Applied to for-4.2/upstream. Thanks,

--
Jiri Kosina
SUSE Labs