2015-05-12 17:00:27

by Laura Abbott

Subject: [PATCH] HID: usbhid: Add HID_QUIRK_NOGET for Aten DVI KVM switch

Like other KVM switches, the Aten DVI KVM switch needs a
quirk to avoid spewing errors:

[791759.606542] usb 1-5.4: input irq status -75 received
[791759.614537] usb 1-5.4: input irq status -75 received
[791759.622542] usb 1-5.4: input irq status -75 received

Add it.

Signed-off-by: Laura Abbott <[email protected]>
---
drivers/hid/hid-ids.h | 1 +
drivers/hid/usbhid/hid-quirks.c | 1 +
2 files changed, 2 insertions(+)

diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 41f167e..7ce93d9 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -164,6 +164,7 @@
#define USB_DEVICE_ID_ATEN_2PORTKVM 0x2204
#define USB_DEVICE_ID_ATEN_4PORTKVM 0x2205
#define USB_DEVICE_ID_ATEN_4PORTKVMC 0x2208
+#define USB_DEVICE_ID_ATEN_CS682 0x2213

#define USB_VENDOR_ID_ATMEL 0x03eb
#define USB_DEVICE_ID_ATMEL_MULTITOUCH 0x211c
diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
index a775143..4696895e 100644
--- a/drivers/hid/usbhid/hid-quirks.c
+++ b/drivers/hid/usbhid/hid-quirks.c
@@ -61,6 +61,7 @@ static const struct hid_blacklist {
{ USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_2PORTKVM, HID_QUIRK_NOGET },
{ USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_4PORTKVM, HID_QUIRK_NOGET },
{ USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_4PORTKVMC, HID_QUIRK_NOGET },
+ { USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_CS682, HID_QUIRK_NOGET },
{ USB_VENDOR_ID_CH, USB_DEVICE_ID_CH_FIGHTERSTICK, HID_QUIRK_NOGET },
{ USB_VENDOR_ID_CH, USB_DEVICE_ID_CH_COMBATSTICK, HID_QUIRK_NOGET },
{ USB_VENDOR_ID_CH, USB_DEVICE_ID_CH_FLIGHT_SIM_ECLIPSE_YOKE, HID_QUIRK_NOGET },
--
2.1.0

2015-05-13 11:25:06

by Jiri Kosina

Subject: Re: [PATCH] HID: usbhid: Add HID_QUIRK_NOGET for Aten DVI KVM switch

On Tue, 12 May 2015, Laura Abbott wrote:

> Like other KVM switches, the Aten DVI KVM switch needs a
> quirk to avoid spewing errors:
>
> [791759.606542] usb 1-5.4: input irq status -75 received
> [791759.614537] usb 1-5.4: input irq status -75 received
> [791759.622542] usb 1-5.4: input irq status -75 received
>
> Add it.
>
> Signed-off-by: Laura Abbott <[email protected]>

Applied for for-4.1/upstream-fixes, thanks.

--
Jiri Kosina
SUSE Labs

2015-05-13 12:03:30

by Oliver Neukum

Subject: Re: [PATCH] HID: usbhid: Add HID_QUIRK_NOGET for Aten DVI KVM switch

On Wed, 2015-05-13 at 13:25 +0200, Jiri Kosina wrote:
> On Tue, 12 May 2015, Laura Abbott wrote:
>
> > Like other KVM switches, the Aten DVI KVM switch needs a
> > quirk to avoid spewing errors:
> >
> > [791759.606542] usb 1-5.4: input irq status -75 received
> > [791759.614537] usb 1-5.4: input irq status -75 received
> > [791759.622542] usb 1-5.4: input irq status -75 received
> >
> > Add it.
> >
> > Signed-off-by: Laura Abbott <[email protected]>
>
> Applied for for-4.1/upstream-fixes, thanks.

Hi,

this should go into stable, too.

Regards
Oliver