2020-10-03 17:28:32

by Byron Stanoszek

[permalink] [raw]
Subject: USBIP is claiming all my USB devices - Commit 7a2f2974f265 is broken

All,

I was testing Linux 5.9-rc7 today when I realized that none of my USB devices
were responding anymore. For instance, my mouse does not respond and its usual
red LED is not on.

Reverting git commit 7a2f2974f265 solved the problem for me.

I have USBIP enabled in my kernel config. Alternatively, removing the following
CONFIG variables also resolved the problem for me:

-CONFIG_USBIP_CORE=y
-CONFIG_USBIP_HOST=y
-CONFIG_USBIP_VHCI_HCD=y
-CONFIG_USBIP_VHCI_HC_PORTS=8
-CONFIG_USBIP_VHCI_NR_HCS=1

I do not have any userland usbip daemons running on this PC.

I attached before-and-after versions of my "dmesg", "lsusb", and "lsusb -t"
outputs to demonstrate the problem. Versions marked .1 are with commit
7a2f2974f265 reverted. Versions marked .2 are without any changes to usbip.

# grep usbip dmesg.1
dmesg.1:usbcore: registered new device driver usbip-host

# grep usbip dmesg.2
dmesg.2:usbcore: registered new device driver usbip-host
dmesg.2:usbip-host 1-8: 1-8 is not in match_busid table... skip!
dmesg.2:usbip-host 1-13: 1-13 is not in match_busid table... skip!

From lsusb_t.1:

/: Bus 01.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/16p, 480M
|__ Port 8: Dev 2, If 0, Class=Human Interface Device, Driver=usbhid, 1.5M
|__ Port 13: Dev 3, If 1, Class=Wireless, Driver=btusb, 12M
|__ Port 13: Dev 3, If 0, Class=Wireless, Driver=btusb, 12M

From lsusb_t.2:

/: Bus 01.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/16p, 480M

(no devices are listed when they should be)

I also attached my .config for review.

Thanks,
-Byron


Attachments:
dmesg.1 (41.26 kB)
dmesg.2 (41.06 kB)
lsusb.1 (542.00 B)
lsusb.2 (542.00 B)
lsusb_t.1 (624.00 B)
lsusb_t.2 (414.00 B)
config-5.9 (113.41 kB)
Download all attachments

2020-10-03 17:29:17

by Greg KH

[permalink] [raw]
Subject: Re: USBIP is claiming all my USB devices - Commit 7a2f2974f265 is broken

On Sat, Oct 03, 2020 at 01:18:36PM -0400, Byron Stanoszek wrote:
> All,
>
> I was testing Linux 5.9-rc7 today when I realized that none of my USB devices
> were responding anymore. For instance, my mouse does not respond and its usual
> red LED is not on.
>
> Reverting git commit 7a2f2974f265 solved the problem for me.
>
> I have USBIP enabled in my kernel config. Alternatively, removing the following
> CONFIG variables also resolved the problem for me:
>
> -CONFIG_USBIP_CORE=y
> -CONFIG_USBIP_HOST=y
> -CONFIG_USBIP_VHCI_HCD=y
> -CONFIG_USBIP_VHCI_HC_PORTS=8
> -CONFIG_USBIP_VHCI_NR_HCS=1
>
> I do not have any userland usbip daemons running on this PC.
>
> I attached before-and-after versions of my "dmesg", "lsusb", and "lsusb -t"
> outputs to demonstrate the problem. Versions marked .1 are with commit
> 7a2f2974f265 reverted. Versions marked .2 are without any changes to usbip.
>
> # grep usbip dmesg.1
> dmesg.1:usbcore: registered new device driver usbip-host
>
> # grep usbip dmesg.2
> dmesg.2:usbcore: registered new device driver usbip-host
> dmesg.2:usbip-host 1-8: 1-8 is not in match_busid table... skip!
> dmesg.2:usbip-host 1-13: 1-13 is not in match_busid table... skip!
>
> > From lsusb_t.1:
>
> /: Bus 01.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/16p, 480M
> |__ Port 8: Dev 2, If 0, Class=Human Interface Device, Driver=usbhid, 1.5M
> |__ Port 13: Dev 3, If 1, Class=Wireless, Driver=btusb, 12M
> |__ Port 13: Dev 3, If 0, Class=Wireless, Driver=btusb, 12M
>
> > From lsusb_t.2:
>
> /: Bus 01.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/16p, 480M
>
> (no devices are listed when they should be)
>
> I also attached my .config for review.

Can you try the patches listed here:
https://lore.kernel.org/r/[email protected]

As this issue should be solved with them. Hopefully :)

thanks,

greg k-h

2020-10-03 17:58:41

by Byron Stanoszek

[permalink] [raw]
Subject: Re: USBIP is claiming all my USB devices - Commit 7a2f2974f265 is broken

On Sat, 3 Oct 2020, Greg Kroah-Hartman wrote:

> On Sat, Oct 03, 2020 at 01:18:36PM -0400, Byron Stanoszek wrote:
>> All,
>>
>> I was testing Linux 5.9-rc7 today when I realized that none of my USB devices
>> were responding anymore. For instance, my mouse does not respond and its usual
>> red LED is not on.
>>
>> Reverting git commit 7a2f2974f265 solved the problem for me.
>
> Can you try the patches listed here:
> https://lore.kernel.org/r/[email protected]
>
> As this issue should be solved with them. Hopefully :)

I confirm this also solved the problem for me.

Thanks,
-Byron

2020-10-04 05:21:25

by Greg KH

[permalink] [raw]
Subject: Re: USBIP is claiming all my USB devices - Commit 7a2f2974f265 is broken

On Sat, Oct 03, 2020 at 01:54:46PM -0400, Byron Stanoszek wrote:
> On Sat, 3 Oct 2020, Greg Kroah-Hartman wrote:
>
> > On Sat, Oct 03, 2020 at 01:18:36PM -0400, Byron Stanoszek wrote:
> > > All,
> > >
> > > I was testing Linux 5.9-rc7 today when I realized that none of my USB devices
> > > were responding anymore. For instance, my mouse does not respond and its usual
> > > red LED is not on.
> > >
> > > Reverting git commit 7a2f2974f265 solved the problem for me.
> >
> > Can you try the patches listed here:
> > https://lore.kernel.org/r/[email protected]
> >
> > As this issue should be solved with them. Hopefully :)
>
> I confirm this also solved the problem for me.

Great! Those patches are now in Linus's tree so all should be good.

thanks for testing and letting me know.

greg k-h