2014-06-07 14:48:29

by Matwey V. Kornilov

Subject: [PATCH] dts: Add UARTs to am335x-bone-common.dtsi

>From 739cee0aded1aac80764b3fca4e801464f199f93 Mon Sep 17 00:00:00 2001
From: "Matwey V. Kornilov" <[email protected]>
Date: Sat, 7 Jun 2014 17:23:57 +0400
Subject: [PATCH] Add UARTs to am335x-bone-common.dtsi

Add four UARTs pinouts and ports to beagle bone common dtsi.

Signed-off-by: Matwey V. Kornilov <[email protected]>
---
arch/arm/boot/dts/am335x-bone-common.dtsi | 48 +++++++++++++++++++++++++++++++
1 file changed, 48 insertions(+)

diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi
index 2e7d932..da3db9f 100644
--- a/arch/arm/boot/dts/am335x-bone-common.dtsi
+++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
@@ -90,6 +90,30 @@
0x174 (PIN_OUTPUT_PULLDOWN | MUX_MODE0) /* uart0_txd.uart0_txd */
>;
};
+ uart1_pins: pinmux_uart1_pins {
+ pinctrl-single,pins = <
+ 0x180 (PIN_INPUT_PULLUP | MUX_MODE0) /* uart1_rxd.uart1_rxd */
+ 0x184 (PIN_OUTPUT_PULLDOWN | MUX_MODE0) /* uart1_txd.uart1_txd */
+ >;
+ };
+ uart2_pins: pinmux_uart2_pins {
+ pinctrl-single,pins = <
+ 0x150 (PIN_INPUT_PULLUP | MUX_MODE1) /* spi0_sclk.uart2_rxd */
+ 0x154 (PIN_OUTPUT_PULLDOWN | MUX_MODE1) /* spi0_d0.uart2_txd */
+ >;
+ };
+ uart3_pins: pinmux_uart3_pins {
+ pinctrl-single,pins = <
+ /* Pin 0x160 spi0_cs1.uart3_rxd is not exported to the expansion header. The port is half-duplex */
+ 0x164 (PIN_OUTPUT_PULLDOWN | MUX_MODE1) /* ecap0_in_pwm0_out.uart3_txd */
+ >;
+ };
+ uart4_pins: pinmux_uart4_pins {
+ pinctrl-single,pins = <
+ 0x070 (PIN_INPUT_PULLUP | MUX_MODE6) /* gpmc_wait0.uart4_rxd */
+ 0x074 (PIN_OUTPUT_PULLDOWN | MUX_MODE6) /* gpmc_wpn.uart4_txd */
+ >;
+ };

clkout2_pin: pinmux_clkout2_pin {
pinctrl-single,pins = <
@@ -179,6 +203,30 @@

status = "okay";
};
+&uart1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&uart1_pins>;
+
+ status = "okay";
+};
+&uart2 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&uart2_pins>;
+
+ status = "okay";
+};
+&uart3 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&uart3_pins>;
+
+ status = "okay";
+};
+&uart4 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&uart4_pins>;
+
+ status = "okay";
+};

&usb {
status = "okay";
--
1.8.1.4

2014-06-07 15:06:16

by Robert Nelson

Subject: Re: [PATCH] dts: Add UARTs to am335x-bone-common.dtsi

On Sat, Jun 7, 2014 at 9:48 AM, Matwey V. Kornilov <[email protected]> wrote:
> From 739cee0aded1aac80764b3fca4e801464f199f93 Mon Sep 17 00:00:00 2001
> From: "Matwey V. Kornilov" <[email protected]>
> Date: Sat, 7 Jun 2014 17:23:57 +0400
> Subject: [PATCH] Add UARTs to am335x-bone-common.dtsi
>
> Add four UARTs pinouts and ports to beagle bone common dtsi.
>
> Signed-off-by: Matwey V. Kornilov <[email protected]>
> ---
> arch/arm/boot/dts/am335x-bone-common.dtsi | 48
> +++++++++++++++++++++++++++++++
> 1 file changed, 48 insertions(+)
>
> diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi
> b/arch/arm/boot/dts/am335x-bone-common.dtsi
> index 2e7d932..da3db9f 100644
> --- a/arch/arm/boot/dts/am335x-bone-common.dtsi
> +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
> @@ -90,6 +90,30 @@
> 0x174 (PIN_OUTPUT_PULLDOWN | MUX_MODE0) /*
> uart0_txd.uart0_txd */
> >;
> };
> + uart1_pins: pinmux_uart1_pins {
> + pinctrl-single,pins = <
> + 0x180 (PIN_INPUT_PULLUP | MUX_MODE0) /*
> uart1_rxd.uart1_rxd */
> + 0x184 (PIN_OUTPUT_PULLDOWN | MUX_MODE0) /*
> uart1_txd.uart1_txd */
> + >;
> + };
> + uart2_pins: pinmux_uart2_pins {
> + pinctrl-single,pins = <
> + 0x150 (PIN_INPUT_PULLUP | MUX_MODE1) /*
> spi0_sclk.uart2_rxd */
> + 0x154 (PIN_OUTPUT_PULLDOWN | MUX_MODE1) /*
> spi0_d0.uart2_txd */
> + >;
> + };
> + uart3_pins: pinmux_uart3_pins {
> + pinctrl-single,pins = <
> + /* Pin 0x160 spi0_cs1.uart3_rxd is not exported to the expansion
> header. The port is half-duplex */
> + 0x164 (PIN_OUTPUT_PULLDOWN | MUX_MODE1) /*
> ecap0_in_pwm0_out.uart3_txd */
> + >;
> + };
> + uart4_pins: pinmux_uart4_pins {
> + pinctrl-single,pins = <
> + 0x070 (PIN_INPUT_PULLUP | MUX_MODE6) /*
> gpmc_wait0.uart4_rxd */
> + 0x074 (PIN_OUTPUT_PULLDOWN | MUX_MODE6) /*
> gpmc_wpn.uart4_txd */
> + >;
> + };
>
> clkout2_pin: pinmux_clkout2_pin {
> pinctrl-single,pins = <
> @@ -179,6 +203,30 @@
>
> status = "okay";
> };
> +&uart1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart1_pins>;
> +
> + status = "okay";
> +};
> +&uart2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart2_pins>;
> +
> + status = "okay";
> +};
> +&uart3 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart3_pins>;
> +
> + status = "okay";
> +};
> +&uart4 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart4_pins>;
> +
> + status = "okay";
> +};

These need to stay disabled in mainline, so drop the status = "okay";
, (till we get a working capemgr/overlay). Otherwise the pinmuxing
looks good.

Regards,

--
Robert Nelson
http://www.rcn-ee.com/

2014-06-07 16:00:26

by Matwey V. Kornilov

Subject: [PATCHv2] dts: Add UARTs to am335x-bone-common.dtsi

>From 570b6d0f050aa00d301e2ee9000c8fcb6db75df1 Mon Sep 17 00:00:00 2001
From: "Matwey V. Kornilov" <[email protected]>
Date: Sat, 7 Jun 2014 17:23:57 +0400
Subject: [PATCH] Add UARTs to am335x-bone-common.dtsi

Add five UARTs pinouts and ports to Beagle Bone common dtsi.

Signed-off-by: Matwey V. Kornilov <[email protected]>
---
Changes from v1 of the patch:
+ add uart5 initially lost
+ left uarts disabled

arch/arm/boot/dts/am335x-bone-common.dtsi | 50 +++++++++++++++++++++++++++++++
1 file changed, 50 insertions(+)

diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi
index 2e7d932..dad68a1 100644
--- a/arch/arm/boot/dts/am335x-bone-common.dtsi
+++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
@@ -90,6 +90,36 @@
0x174 (PIN_OUTPUT_PULLDOWN | MUX_MODE0) /* uart0_txd.uart0_txd */
>;
};
+ uart1_pins: pinmux_uart1_pins {
+ pinctrl-single,pins = <
+ 0x180 (PIN_INPUT_PULLUP | MUX_MODE0) /* uart1_rxd.uart1_rxd */
+ 0x184 (PIN_OUTPUT_PULLDOWN | MUX_MODE0) /* uart1_txd.uart1_txd */
+ >;
+ };
+ uart2_pins: pinmux_uart2_pins {
+ pinctrl-single,pins = <
+ 0x150 (PIN_INPUT_PULLUP | MUX_MODE1) /* spi0_sclk.uart2_rxd */
+ 0x154 (PIN_OUTPUT_PULLDOWN | MUX_MODE1) /* spi0_d0.uart2_txd */
+ >;
+ };
+ uart3_pins: pinmux_uart3_pins {
+ pinctrl-single,pins = <
+ /* Pin 0x160 spi0_cs1.uart3_rxd is not exported to the expansion header. The port is half-duplex */
+ 0x164 (PIN_OUTPUT_PULLDOWN | MUX_MODE1) /* ecap0_in_pwm0_out.uart3_txd */
+ >;
+ };
+ uart4_pins: pinmux_uart4_pins {
+ pinctrl-single,pins = <
+ 0x070 (PIN_INPUT_PULLUP | MUX_MODE6) /* gpmc_wait0.uart4_rxd */
+ 0x074 (PIN_OUTPUT_PULLDOWN | MUX_MODE6) /* gpmc_wpn.uart4_txd */
+ >;
+ };
+ uart5_pins: pinmux_uart5_pins {
+ pinctrl-single,pins = <
+ 0x0c4 (PIN_INPUT_PULLUP | MUX_MODE4) /* lcd_data9.uart5_rxd */
+ 0x0c0 (PIN_OUTPUT_PULLDOWN | MUX_MODE4) /* lcd_data8.uart5_txd */
+ >;
+ };

clkout2_pin: pinmux_clkout2_pin {
pinctrl-single,pins = <
@@ -179,6 +209,26 @@

status = "okay";
};
+&uart1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&uart1_pins>;
+};
+&uart2 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&uart2_pins>;
+};
+&uart3 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&uart3_pins>;
+};
+&uart4 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&uart4_pins>;
+};
+&uart5 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&uart5_pins>;
+};

&usb {
status = "okay";
--
1.8.1.4

2014-06-07 16:19:41

by Matwey V. Kornilov

Subject: Re: [PATCH] dts: Add UARTs to am335x-bone-common.dtsi

On Sat, 7 Jun 2014, Robert Nelson wrote:
> These need to stay disabled in mainline, so drop the status = "okay";
> , (till we get a working capemgr/overlay). Otherwise the pinmuxing
> looks good.

What chances that we will eventually have working overlay in the mainline?