2019-03-26 23:09:42

by Jann Horn

Subject: [PATCH] Yama: mark local symbols as static

sparse complains that Yama defines functions and a variable as non-static
even though they don't exist in any header. Fix it by making them static.

Signed-off-by: Jann Horn <[email protected]>
---
security/yama/yama_lsm.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/security/yama/yama_lsm.c b/security/yama/yama_lsm.c
index 57cc60722dd3..06b14a57b0a4 100644
--- a/security/yama/yama_lsm.c
+++ b/security/yama/yama_lsm.c
@@ -206,7 +206,7 @@ static void yama_ptracer_del(struct task_struct *tracer,
* yama_task_free - check for task_pid to remove from exception list
* @task: task being removed
*/
-void yama_task_free(struct task_struct *task)
+static void yama_task_free(struct task_struct *task)
{
yama_ptracer_del(task, task);
}
@@ -401,7 +401,7 @@ static int yama_ptrace_access_check(struct task_struct *child,
*
* Returns 0 if following the ptrace is allowed, -ve on error.
*/
-int yama_ptrace_traceme(struct task_struct *parent)
+static int yama_ptrace_traceme(struct task_struct *parent)
{
int rc = 0;

@@ -452,7 +452,7 @@ static int yama_dointvec_minmax(struct ctl_table *table, int write,
static int zero;
static int max_scope = YAMA_SCOPE_NO_ATTACH;

-struct ctl_path yama_sysctl_path[] = {
+static struct ctl_path yama_sysctl_path[] = {
{ .procname = "kernel", },
{ .procname = "yama", },
{ }
--
2.21.0.392.gf8f6787159e-goog

2019-03-27 12:44:02

by Mukesh Ojha

Subject: Re: [PATCH] Yama: mark local symbols as static

On 3/27/2019 4:38 AM, Jann Horn wrote:
> sparse complains that Yama defines functions and a variable as non-static
> even though they don't exist in any header. Fix it by making them static.
>
> Signed-off-by: Jann Horn <[email protected]>

Reviewed-by: Mukesh Ojha <[email protected]>


> ---
> security/yama/yama_lsm.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/security/yama/yama_lsm.c b/security/yama/yama_lsm.c
> index 57cc60722dd3..06b14a57b0a4 100644
> --- a/security/yama/yama_lsm.c
> +++ b/security/yama/yama_lsm.c
> @@ -206,7 +206,7 @@ static void yama_ptracer_del(struct task_struct *tracer,
> * yama_task_free - check for task_pid to remove from exception list
> * @task: task being removed
> */
> -void yama_task_free(struct task_struct *task)
> +static void yama_task_free(struct task_struct *task)
> {
> yama_ptracer_del(task, task);
> }
> @@ -401,7 +401,7 @@ static int yama_ptrace_access_check(struct task_struct *child,
> *
> * Returns 0 if following the ptrace is allowed, -ve on error.
> */
> -int yama_ptrace_traceme(struct task_struct *parent)
> +static int yama_ptrace_traceme(struct task_struct *parent)
> {
> int rc = 0;
>
> @@ -452,7 +452,7 @@ static int yama_dointvec_minmax(struct ctl_table *table, int write,
> static int zero;
> static int max_scope = YAMA_SCOPE_NO_ATTACH;
>
> -struct ctl_path yama_sysctl_path[] = {
> +static struct ctl_path yama_sysctl_path[] = {
> { .procname = "kernel", },
> { .procname = "yama", },
> { }

2019-04-10 19:06:10

by James Morris

Subject: Re: [PATCH] Yama: mark local symbols as static

On Wed, 27 Mar 2019, Jann Horn wrote:

> sparse complains that Yama defines functions and a variable as non-static
> even though they don't exist in any header. Fix it by making them static.
>
> Signed-off-by: Jann Horn <[email protected]>

Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next-general

--
James Morris
<[email protected]>