2020-01-21 08:51:35

by Alex Shi

Subject: [PATCH] security: remove EARLY_LSM_COUNT which never used

This macro is never used from it was introduced in commit e6b1db98cf4d5
("security: Support early LSMs"), better to remove it.

Signed-off-by: Alex Shi <[email protected]>
Cc: Matthew Garrett <[email protected]>
Cc: James Morris <[email protected]>
Cc: "Serge E. Hallyn" <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
security/security.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/security/security.c b/security/security.c
index cd2d18d2d279..b9771de83cf7 100644
--- a/security/security.c
+++ b/security/security.c
@@ -33,7 +33,6 @@

/* How many LSMs were built into the kernel? */
#define LSM_COUNT (__end_lsm_info - __start_lsm_info)
-#define EARLY_LSM_COUNT (__end_early_lsm_info - __start_early_lsm_info)

struct security_hook_heads security_hook_heads __lsm_ro_after_init;
static BLOCKING_NOTIFIER_HEAD(blocking_lsm_notifier_chain);
--
1.8.3.1

2020-01-23 17:40:29

by Serge E. Hallyn

Subject: Re: [PATCH] security: remove EARLY_LSM_COUNT which never used

On Tue, Jan 21, 2020 at 04:50:03PM +0800, Alex Shi wrote:
> This macro is never used from it was introduced in commit e6b1db98cf4d5
> ("security: Support early LSMs"), better to remove it.
>
> Signed-off-by: Alex Shi <[email protected]>
> Cc: Matthew Garrett <[email protected]>
> Cc: James Morris <[email protected]>
> Cc: "Serge E. Hallyn" <[email protected]>

Acked-by: Serge Hallyn <[email protected]>

Does indeed seem unused.

> Cc: [email protected]
> Cc: [email protected]
> ---
> security/security.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/security/security.c b/security/security.c
> index cd2d18d2d279..b9771de83cf7 100644
> --- a/security/security.c
> +++ b/security/security.c
> @@ -33,7 +33,6 @@
>
> /* How many LSMs were built into the kernel? */
> #define LSM_COUNT (__end_lsm_info - __start_lsm_info)
> -#define EARLY_LSM_COUNT (__end_early_lsm_info - __start_early_lsm_info)
>
> struct security_hook_heads security_hook_heads __lsm_ro_after_init;
> static BLOCKING_NOTIFIER_HEAD(blocking_lsm_notifier_chain);
> --
> 1.8.3.1

2020-01-24 00:02:19

by James Morris

Subject: Re: [PATCH] security: remove EARLY_LSM_COUNT which never used

On Tue, 21 Jan 2020, Alex Shi wrote:

> This macro is never used from it was introduced in commit e6b1db98cf4d5
> ("security: Support early LSMs"), better to remove it.
>
> Signed-off-by: Alex Shi <[email protected]>

Thanks, applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next-general

--
James Morris
<[email protected]>