2020-02-18 04:05:16

by Hugh Dickins

Subject: [PATCH] tmpfs: deny and force are not huge mount options

5.6-rc1 commit 2710c957a8ef ("fs_parse: get rid of ->enums") regressed
the huge tmpfs mount options to an earlier state: "deny" and "force"
are not valid there, and can crash the kernel. Delete those lines.

Signed-off-by: Hugh Dickins <[email protected]>
---

mm/shmem.c | 2 --
1 file changed, 2 deletions(-)

--- 5.6-rc2/mm/shmem.c 2020-02-09 17:36:41.798976778 -0800
+++ linux/mm/shmem.c 2020-02-17 19:27:22.704093986 -0800
@@ -3386,8 +3386,6 @@ static const struct constant_table shmem
{"always", SHMEM_HUGE_ALWAYS },
{"within_size", SHMEM_HUGE_WITHIN_SIZE },
{"advise", SHMEM_HUGE_ADVISE },
- {"deny", SHMEM_HUGE_DENY },
- {"force", SHMEM_HUGE_FORCE },
{}
};

2020-02-18 20:09:01

by Al Viro

Subject: Re: [PATCH] tmpfs: deny and force are not huge mount options

On Mon, Feb 17, 2020 at 08:04:19PM -0800, Hugh Dickins wrote:
> 5.6-rc1 commit 2710c957a8ef ("fs_parse: get rid of ->enums") regressed
> the huge tmpfs mount options to an earlier state: "deny" and "force"
> are not valid there, and can crash the kernel. Delete those lines.

Applied to #fixes, will send to Linus tonight.