2023-01-14 09:27:09

by Christophe JAILLET

Subject: [PATCH v2] kernel/params.c: Use kstrtobool() instead of strtobool()

strtobool() is the same as kstrtobool().
However, the latter is more used within the kernel.

In order to remove strtobool() and slightly simplify kstrtox.h, switch to
the other function name.

While at it, include the corresponding header file (<linux/kstrtox.h>)

Signed-off-by: Christophe JAILLET <[email protected]>
---
This patch was already sent as a part of a serie ([1]) that axed all usages
of strtobool().
Most of the patches have been merged in -next.

I synch'ed with latest -next and re-send the remaining ones as individual
patches.

Note that the first version was sent to no-one, only mailing lists,
because "get_maintainer.pl --nogit-fallback" returns an empty list.

Changes in v2:
- No change

[1]: https://lore.kernel.org/all/[email protected]/

Signed-off-by: Christophe JAILLET <[email protected]>
---
kernel/params.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/params.c b/kernel/params.c
index 14d66070757b..6e34ca89ebae 100644
--- a/kernel/params.c
+++ b/kernel/params.c
@@ -4,6 +4,7 @@

*/
#include <linux/kernel.h>
+#include <linux/kstrtox.h>
#include <linux/string.h>
#include <linux/errno.h>
#include <linux/module.h>
@@ -310,7 +311,7 @@ int param_set_bool(const char *val, const struct kernel_param *kp)
if (!val) val = "1";

/* One of =[yYnN01] */
- return strtobool(val, kp->arg);
+ return kstrtobool(val, kp->arg);
}
EXPORT_SYMBOL(param_set_bool);

--
2.34.1

2023-01-17 15:20:31

by Miroslav Benes

Subject: Re: [PATCH v2] kernel/params.c: Use kstrtobool() instead of strtobool()

On Sat, 14 Jan 2023, Christophe JAILLET wrote:

> strtobool() is the same as kstrtobool().
> However, the latter is more used within the kernel.
>
> In order to remove strtobool() and slightly simplify kstrtox.h, switch to
> the other function name.
>
> While at it, include the corresponding header file (<linux/kstrtox.h>)
>
> Signed-off-by: Christophe JAILLET <[email protected]>

Reviewed-by: Miroslav Benes <[email protected]>

Luis, will you take it through your modules tree?

M

2023-01-17 16:28:05

by Luis Chamberlain

Subject: Re: [PATCH v2] kernel/params.c: Use kstrtobool() instead of strtobool()

On Tue, Jan 17, 2023 at 03:51:52PM +0100, Miroslav Benes wrote:
> On Sat, 14 Jan 2023, Christophe JAILLET wrote:
>
> > strtobool() is the same as kstrtobool().
> > However, the latter is more used within the kernel.
> >
> > In order to remove strtobool() and slightly simplify kstrtox.h, switch to
> > the other function name.
> >
> > While at it, include the corresponding header file (<linux/kstrtox.h>)
> >
> > Signed-off-by: Christophe JAILLET <[email protected]>
>
> Reviewed-by: Miroslav Benes <[email protected]>
>
> Luis, will you take it through your modules tree?

Yes, queued up, thanks!

Luis