2020-03-12 13:32:35

by Neil Armstrong

Subject: [PATCH 5/9] spi: meson-spicc: add min sclk for each compatible

The G12A SPICC controller variant takes the source clock from a specific
clock instead of the bus clock.
The minimal clock calculus won't work with the G12A support, thus add the
minimal supported clock for each variant and pass this to the SPI core.

Signed-off-by: Neil Armstrong <[email protected]>
---
drivers/spi/spi-meson-spicc.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/spi/spi-meson-spicc.c b/drivers/spi/spi-meson-spicc.c
index 710b4e780daa..b5bd3a897e8f 100644
--- a/drivers/spi/spi-meson-spicc.c
+++ b/drivers/spi/spi-meson-spicc.c
@@ -132,6 +132,7 @@

struct meson_spicc_data {
unsigned int max_speed_hz;
+ unsigned int min_speed_hz;
bool has_oen;
bool has_enhance_clk_div;
};
@@ -685,7 +686,7 @@ static int meson_spicc_probe(struct platform_device *pdev)
SPI_BPW_MASK(16) |
SPI_BPW_MASK(8);
master->flags = (SPI_MASTER_MUST_RX | SPI_MASTER_MUST_TX);
- master->min_speed_hz = rate >> 9;
+ master->min_speed_hz = spicc->data->min_speed_hz;
master->setup = meson_spicc_setup;
master->cleanup = meson_spicc_cleanup;
master->prepare_message = meson_spicc_prepare_message;
@@ -736,10 +737,12 @@ static int meson_spicc_remove(struct platform_device *pdev)

static const struct meson_spicc_data meson_spicc_gx_data = {
.max_speed_hz = 30000000,
+ .min_speed_hz = 325000,
};

static const struct meson_spicc_data meson_spicc_axg_data = {
.max_speed_hz = 80000000,
+ .min_speed_hz = 325000,
.has_oen = true,
.has_enhance_clk_div = true,
};
--
2.22.0

2020-03-12 17:39:58

by Mark Brown

Subject: Applied "spi: meson-spicc: add min sclk for each compatible" to the spi tree

The patch

spi: meson-spicc: add min sclk for each compatible

has been applied to the spi tree at

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

From 8791068dab979819e01f41736953b9b2e462867b Mon Sep 17 00:00:00 2001
From: Neil Armstrong <[email protected]>
Date: Thu, 12 Mar 2020 14:31:27 +0100
Subject: [PATCH] spi: meson-spicc: add min sclk for each compatible

The G12A SPICC controller variant takes the source clock from a specific
clock instead of the bus clock.
The minimal clock calculus won't work with the G12A support, thus add the
minimal supported clock for each variant and pass this to the SPI core.

Signed-off-by: Neil Armstrong <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
---
drivers/spi/spi-meson-spicc.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/spi/spi-meson-spicc.c b/drivers/spi/spi-meson-spicc.c
index 710b4e780daa..b5bd3a897e8f 100644
--- a/drivers/spi/spi-meson-spicc.c
+++ b/drivers/spi/spi-meson-spicc.c
@@ -132,6 +132,7 @@

struct meson_spicc_data {
unsigned int max_speed_hz;
+ unsigned int min_speed_hz;
bool has_oen;
bool has_enhance_clk_div;
};
@@ -685,7 +686,7 @@ static int meson_spicc_probe(struct platform_device *pdev)
SPI_BPW_MASK(16) |
SPI_BPW_MASK(8);
master->flags = (SPI_MASTER_MUST_RX | SPI_MASTER_MUST_TX);
- master->min_speed_hz = rate >> 9;
+ master->min_speed_hz = spicc->data->min_speed_hz;
master->setup = meson_spicc_setup;
master->cleanup = meson_spicc_cleanup;
master->prepare_message = meson_spicc_prepare_message;
@@ -736,10 +737,12 @@ static int meson_spicc_remove(struct platform_device *pdev)

static const struct meson_spicc_data meson_spicc_gx_data = {
.max_speed_hz = 30000000,
+ .min_speed_hz = 325000,
};

static const struct meson_spicc_data meson_spicc_axg_data = {
.max_speed_hz = 80000000,
+ .min_speed_hz = 325000,
.has_oen = true,
.has_enhance_clk_div = true,
};
--
2.20.1