2007-01-25 09:16:10

by Ken Chen

[permalink] [raw]
Subject: Re: [RFC] mm: Move common segments checks to separate function

Dmitriy Monakhov wrote on Jan 24, 11:00 pm
> > Move common segments checks from __generic_file_aio_{read,write}_nolock()
> > to separate helper function generic_segment_checks().WOW my eyes ....
> I'm realy sorry but this patch is litle bit broken. :(
> I've forgot to check generic_segment_checks() return value.

why not remove the for loop all together? like this:

http://groups.google.com/group/linux.kernel/browse_frm/thread/97550ddba48c8c8b/623ddad30b547702?lnk=st&q=&rnum=9#623ddad30b547702