2008-11-06 19:11:08

by Ken Chen

Subject: [patch] enable wchan config menu item for x86-64

Ingo,

I don't know when will you phase out /proc/pid/wchan. Can we enable the
wchan config menu item for now on x86-64 arch? This will at least allow
people to enable/disable frame pointers on scheduler functions.

Signed-off-by: Ken Chen <[email protected]>

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index e60c59b..38f9fb9 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -367,7 +367,7 @@ config X86_RDC321X
config SCHED_NO_NO_OMIT_FRAME_POINTER
def_bool y
prompt "Single-depth WCHAN output"
- depends on X86_32
+ depends on X86
help
Calculate simpler /proc/<PID>/wchan values. If this option
is disabled then wchan values will recurse back to the

2008-11-06 21:26:00

by Ingo Molnar

Subject: Re: [patch] enable wchan config menu item for x86-64

* Ken Chen <[email protected]> wrote:

> Ingo,
>
> I don't know when will you phase out /proc/pid/wchan. Can we enable the
> wchan config menu item for now on x86-64 arch? This will at least allow
> people to enable/disable frame pointers on scheduler functions.
>
> Signed-off-by: Ken Chen <[email protected]>
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index e60c59b..38f9fb9 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -367,7 +367,7 @@ config X86_RDC321X
> config SCHED_NO_NO_OMIT_FRAME_POINTER
> def_bool y
> prompt "Single-depth WCHAN output"
> - depends on X86_32
> + depends on X86

makes sense, i've added it to tip/sched/core, thanks Ken!

This will need some testing as we never did this on 64-bit, so it's
definitely a v2.6.29 item.

Ingo