2008-12-16 07:06:53

by Ken Chen

[permalink] [raw]
Subject: [patch 2/2] cpuacct: export percpu cpuacct cgroup stats

sorry, forgot to cc lkml on initial post.

---------- Forwarded message ----------
From: Ken Chen <[email protected]>
Date: Mon, Dec 15, 2008 at 10:04 PM
Subject: [patch 2/2] cpuacct: export percpu cpuacct cgroup stats
To: Ingo Molnar <[email protected]>, Andrew Morton
<[email protected]>, Paul Menage <[email protected]>, Li Zefan
<[email protected]>


This patch export per-cpu CPU cycle usage for a given cpuacct cgroup.
There is a need for a user space monitor daemon to track group CPU
usage on per-cpu base. It is also useful for monitoring CFS load
balancer behavior by tracking per CPU group usage.

Signed-off-by: Ken Chen <[email protected]>
Reviewed-by: Li Zefan <[email protected]>
Reviewed-by: Andrew Morton <[email protected]>

diff --git a/kernel/sched.c b/kernel/sched.c
index 124bd7a..cfdaace 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -9369,12 +9369,32 @@ out:
return err;
}

+static int cpuacct_percpu_seq_read(struct cgroup *cgroup, struct cftype *cft,
+ struct seq_file *m)
+{
+ struct cpuacct *ca = cgroup_ca(cgroup);
+ u64 percpu;
+ int i;
+
+ for_each_present_cpu(i) {
+ percpu = cpuacct_cpuusage_read(ca, i);
+ seq_printf(m, "%llu ", (unsigned long long) percpu);
+ }
+ seq_printf(m, "\n");
+ return 0;
+}
+
static struct cftype files[] = {
{
.name = "usage",
.read_u64 = cpuusage_read,
.write_u64 = cpuusage_write,
},
+ {
+ .name = "usage_percpu",
+ .read_seq_string = cpuacct_percpu_seq_read,
+ },
+
};

static int cpuacct_populate(struct cgroup_subsys *ss, struct cgroup *cgrp)


2008-12-16 11:16:31

by Ingo Molnar

[permalink] [raw]
Subject: Re: [patch 2/2] cpuacct: export percpu cpuacct cgroup stats


* Ken Chen <[email protected]> wrote:

> This patch export per-cpu CPU cycle usage for a given cpuacct cgroup.
> There is a need for a user space monitor daemon to track group CPU usage
> on per-cpu base. It is also useful for monitoring CFS load balancer
> behavior by tracking per CPU group usage.
>
> Signed-off-by: Ken Chen <[email protected]>
> Reviewed-by: Li Zefan <[email protected]>
> Reviewed-by: Andrew Morton <[email protected]>

applied to tip/sched/core, thanks Ken!

Ingo