2021-06-22 12:46:33

by Vincent Pelletier

[permalink] [raw]
Subject: [PATCH v3 1/2] regulator: da9063: Use __stringify_1

Indirect stringification is not intended here, and generated names may
unintentionally conflict with macros.

Signed-off-by: Vincent Pelletier <[email protected]>
---
V2 -> V3: no change
V1 -> V2:
- new patch for a cosmetic bug uncovered by 2/2
- cc linux-kernel ML
- fix subject prefix

drivers/regulator/da9063-regulator.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/da9063-regulator.c b/drivers/regulator/da9063-regulator.c
index cf7d5341750e..21f4ddb37b09 100644
--- a/drivers/regulator/da9063-regulator.c
+++ b/drivers/regulator/da9063-regulator.c
@@ -88,7 +88,7 @@ struct da9063_regulator_info {
/* Macros for LDO */
#define DA9063_LDO(chip, regl_name, min_mV, step_mV, max_mV) \
.desc.id = chip##_ID_##regl_name, \
- .desc.name = __stringify(chip##_##regl_name), \
+ .desc.name = __stringify_1(chip##_##regl_name), \
.desc.ops = &da9063_ldo_ops, \
.desc.min_uV = (min_mV) * 1000, \
.desc.uV_step = (step_mV) * 1000, \
@@ -108,7 +108,7 @@ struct da9063_regulator_info {
#define DA9063_BUCK(chip, regl_name, min_mV, step_mV, max_mV, limits_array, \
creg, cmask) \
.desc.id = chip##_ID_##regl_name, \
- .desc.name = __stringify(chip##_##regl_name), \
+ .desc.name = __stringify_1(chip##_##regl_name), \
.desc.ops = &da9063_buck_ops, \
.desc.min_uV = (min_mV) * 1000, \
.desc.uV_step = (step_mV) * 1000, \
--
2.32.0


2021-06-22 13:13:52

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH v3 1/2] regulator: da9063: Use __stringify_1

On Tue, Jun 22, 2021 at 12:45:19PM +0000, Vincent Pelletier wrote:
> Indirect stringification is not intended here, and generated names may
> unintentionally conflict with macros.

Please don't submit new patches in reply to old serieses, it makes it
easy for things to get missed and creates confusion about what the
current versions of things are. It's better to post new things as
independent serieses.


Attachments:
(No filename) (415.00 B)
signature.asc (499.00 B)
Download all attachments