2024-02-01 22:46:34

by Marc Zyngier

Subject: [PATCH] md/linear: Get rid of md-linear.h

Given that 849d18e27be9 ("md: Remove deprecated CONFIG_MD_LINEAR")
killed the linear flavour of MD, it seems only logical to drop
the leftover include file that used to come with it.

I also feel that it should be my own privilege to remove my 30 year
old attempt at writing kernel code ;-). RIP!

Cc: Song Liu <[email protected]>
Cc: Yu Kuai <[email protected]>
Signed-off-by: Marc Zyngier <[email protected]>
---
drivers/md/md-linear.h | 17 -----------------
1 file changed, 17 deletions(-)
delete mode 100644 drivers/md/md-linear.h

diff --git a/drivers/md/md-linear.h b/drivers/md/md-linear.h
deleted file mode 100644
index 5587eeedb882..000000000000
--- a/drivers/md/md-linear.h
+++ /dev/null
@@ -1,17 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-#ifndef _LINEAR_H
-#define _LINEAR_H
-
-struct dev_info {
- struct md_rdev *rdev;
- sector_t end_sector;
-};
-
-struct linear_conf
-{
- struct rcu_head rcu;
- sector_t array_sectors;
- int raid_disks; /* a copy of mddev->raid_disks */
- struct dev_info disks[] __counted_by(raid_disks);
-};
-#endif
--
2.39.2

2024-02-02 01:08:52

by Yu Kuai

Subject: Re: [PATCH] md/linear: Get rid of md-linear.h

?? 2024/02/02 6:45, Marc Zyngier д??:
> Given that 849d18e27be9 ("md: Remove deprecated CONFIG_MD_LINEAR")
> killed the linear flavour of MD, it seems only logical to drop
> the leftover include file that used to come with it.
>
> I also feel that it should be my own privilege to remove my 30 year
> old attempt at writing kernel code ;-). RIP!
>
> Cc: Song Liu <[email protected]>
> Cc: Yu Kuai <[email protected]>
> Signed-off-by: Marc Zyngier <[email protected]>

LGTM
Reviewed-by: Yu Kuai <[email protected]>

> ---
> drivers/md/md-linear.h | 17 -----------------
> 1 file changed, 17 deletions(-)
> delete mode 100644 drivers/md/md-linear.h
>
> diff --git a/drivers/md/md-linear.h b/drivers/md/md-linear.h
> deleted file mode 100644
> index 5587eeedb882..000000000000
> --- a/drivers/md/md-linear.h
> +++ /dev/null
> @@ -1,17 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 */
> -#ifndef _LINEAR_H
> -#define _LINEAR_H
> -
> -struct dev_info {
> - struct md_rdev *rdev;
> - sector_t end_sector;
> -};
> -
> -struct linear_conf
> -{
> - struct rcu_head rcu;
> - sector_t array_sectors;
> - int raid_disks; /* a copy of mddev->raid_disks */
> - struct dev_info disks[] __counted_by(raid_disks);
> -};
> -#endif
>

2024-02-05 23:44:04

by Song Liu

Subject: Re: [PATCH] md/linear: Get rid of md-linear.h

On Thu, Feb 1, 2024 at 5:08 PM Yu Kuai <[email protected]> wrote:
>
> 在 2024/02/02 6:45, Marc Zyngier 写道:
> > Given that 849d18e27be9 ("md: Remove deprecated CONFIG_MD_LINEAR")
> > killed the linear flavour of MD, it seems only logical to drop
> > the leftover include file that used to come with it.
> >
> > I also feel that it should be my own privilege to remove my 30 year
> > old attempt at writing kernel code ;-). RIP!
> >
> > Cc: Song Liu <[email protected]>
> > Cc: Yu Kuai <[email protected]>
> > Signed-off-by: Marc Zyngier <[email protected]>
>
> LGTM
> Reviewed-by: Yu Kuai <[email protected]>

Applied to md-6.9. Thanks!

Song