2018-06-22 21:42:34

by Jeffrin Jose T

Subject: [PATCH v2] selftests: bpf: notification about privilege required to run test_lwt_seg6local.sh testing script

This test needs root privilege for it's successful execution.

This patch is atleast used to notify the user about the privilege
the script demands for the smooth execution of the test.

Signed-off-by: Jeffrin Jose T (Rajagiri SET) <[email protected]>
---
tools/testing/selftests/bpf/test_lwt_seg6local.sh | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/tools/testing/selftests/bpf/test_lwt_seg6local.sh b/tools/testing/selftests/bpf/test_lwt_seg6local.sh
index 1c77994b5e71..30575577a8b2 100755
--- a/tools/testing/selftests/bpf/test_lwt_seg6local.sh
+++ b/tools/testing/selftests/bpf/test_lwt_seg6local.sh
@@ -21,6 +21,15 @@
# An UDP datagram is sent from fb00::1 to fb00::6. The test succeeds if this
# datagram can be read on NS6 when binding to fb00::6.

+# Kselftest framework requirement - SKIP code is 4.
+ksft_skip=4
+
+msg="skip all tests:"
+if [ $UID != 0 ]; then
+ echo $msg please run this as root >&2
+ exit $ksft_skip
+fi
+
TMP_FILE="/tmp/selftest_lwt_seg6local.txt"

cleanup()
--
2.17.0

2018-06-26 05:34:29

by Song Liu

Subject: Re: [PATCH v2] selftests: bpf: notification about privilege required to run test_lwt_seg6local.sh testing script

On Fri, Jun 22, 2018 at 2:40 PM, Jeffrin Jose T <[email protected]> wrote:
> This test needs root privilege for it's successful execution.
>
> This patch is atleast used to notify the user about the privilege
> the script demands for the smooth execution of the test.
>
> Signed-off-by: Jeffrin Jose T (Rajagiri SET) <[email protected]>

Acked-by: Song Liu <[email protected]>

> ---
> tools/testing/selftests/bpf/test_lwt_seg6local.sh | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/tools/testing/selftests/bpf/test_lwt_seg6local.sh b/tools/testing/selftests/bpf/test_lwt_seg6local.sh
> index 1c77994b5e71..30575577a8b2 100755
> --- a/tools/testing/selftests/bpf/test_lwt_seg6local.sh
> +++ b/tools/testing/selftests/bpf/test_lwt_seg6local.sh
> @@ -21,6 +21,15 @@
> # An UDP datagram is sent from fb00::1 to fb00::6. The test succeeds if this
> # datagram can be read on NS6 when binding to fb00::6.
>
> +# Kselftest framework requirement - SKIP code is 4.
> +ksft_skip=4
> +
> +msg="skip all tests:"
> +if [ $UID != 0 ]; then
> + echo $msg please run this as root >&2
> + exit $ksft_skip
> +fi
> +
> TMP_FILE="/tmp/selftest_lwt_seg6local.txt"
>
> cleanup()
> --
> 2.17.0
>

2018-06-26 10:23:28

by Daniel Borkmann

Subject: Re: [PATCH v2] selftests: bpf: notification about privilege required to run test_lwt_seg6local.sh testing script

On 06/22/2018 11:40 PM, Jeffrin Jose T wrote:
> This test needs root privilege for it's successful execution.
>
> This patch is atleast used to notify the user about the privilege
> the script demands for the smooth execution of the test.
>
> Signed-off-by: Jeffrin Jose T (Rajagiri SET) <[email protected]>

Applied to bpf, thanks Jeffrin!