These patches adds the stingray thermal driver and its
corresponding DT nodes with documentation.
Changes from v3
- Addressed Daniel lezcano comments.
- Elaborated commit description of thermal driver patch.
- Added brcm,max-crit-temp DT parameter.
Changes from v2:
- All stingray TMON DT nodes are combine together into single.
Temperature registers are combined into one mem resource.
brcm,tmon-mask parameter has available TMONs mask value.
- All available TMONs are initialized together in single
instance of driver probe call.
Changes from v1:
- Fixed auto build sparce warning.
Pramod Kumar (3):
dt-bindings: thermal: Add binding document for SR thermal
arm64: dts: stingray: Add Stingray Thermal DT support.
thermal: broadcom: Add Stingray thermal driver
.../bindings/thermal/brcm,sr-thermal.txt | 25 +++
.../arm64/boot/dts/broadcom/stingray/stingray.dtsi | 14 ++
drivers/thermal/Kconfig | 3 +-
drivers/thermal/broadcom/Kconfig | 9 +
drivers/thermal/broadcom/Makefile | 1 +
drivers/thermal/broadcom/sr-thermal.c | 203 +++++++++++++++++++++
6 files changed, 254 insertions(+), 1 deletion(-)
create mode 100644 Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt
create mode 100644 drivers/thermal/broadcom/sr-thermal.c
--
2.7.4
From: Pramod Kumar <[email protected]>
Add binding document for supported thermal implementation
in Stingray.
Signed-off-by: Pramod Kumar <[email protected]>
Signed-off-by: Srinath Mannam <[email protected]>
Reviewed-by: Ray Jui <[email protected]>
Reviewed-by: Scott Branden <[email protected]>
---
.../bindings/thermal/brcm,sr-thermal.txt | 25 ++++++++++++++++++++++
1 file changed, 25 insertions(+)
create mode 100644 Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt
diff --git a/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt b/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt
new file mode 100644
index 0000000..717617b
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt
@@ -0,0 +1,25 @@
+* Broadcom Stingray Thermal
+
+This binding describes thermal sensors that is part of Stingray SoCs.
+
+Required properties:
+- compatible : Must be "brcm,sr-thermal"
+- reg : memory where tmon data will be available.
+- brcm,tmon-mask: A one cell bit mask of valid TMON sources.
+ Each bit represents single TMON source.
+- brcm,max-crit-temp: Maximum supported critical temperature.
+
+Example:
+ tmons {
+ compatible = "simple-bus";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x0 0x0 0x8f100000 0x100>;
+
+ tmon: thermal@0 {
+ compatible = "brcm,sr-thermal";
+ reg = <0 0x40>;
+ brcm,tmon-mask = <0x3f>;
+ brcm,max-crit-temp = <105000>;
+ };
+ };
--
2.7.4
From: Pramod Kumar <[email protected]>
Add DT nodes for thermal zones memory base address
to read temperature.
Signed-off-by: Pramod Kumar <[email protected]>
Signed-off-by: Srinath Mannam <[email protected]>
Reviewed-by: Ray Jui <[email protected]>
Reviewed-by: Scott Branden <[email protected]>
---
arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi b/arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi
index e283480..a30985c 100644
--- a/arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi
+++ b/arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi
@@ -612,4 +612,18 @@
status = "disabled";
};
};
+
+ tmons {
+ compatible = "simple-bus";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x0 0x0 0x8f100000 0x100>;
+
+ tmon: thermal@0 {
+ compatible = "brcm,sr-thermal";
+ reg = <0x0 0x40>;
+ brcm,tmon-mask = <0x3f>;
+ brcm,max-crit-temp = <105000>;
+ };
+ };
};
--
2.7.4
From: Pramod Kumar <[email protected]>
Stingray SoC has six temperature sensor and those are
configured, controlled and accessed to read temperature
and update in DDR memory using m0 firmware.
All six sensors has been given 4 bytes of memory in DDR
to write temperature in millivolts.
This thermal driver read temperature values from DDR
because no direct access to sensors.
Like this all temparature sensors are monitored and
trips at critical temperature.
If driver can't handle thermal runaways because of
any unknown reason, then firmware in m0 Processor
will handle.
Signed-off-by: Pramod Kumar <[email protected]>
Signed-off-by: Srinath Mannam <[email protected]>
Reviewed-by: Ray Jui <[email protected]>
Reviewed-by: Scott Branden <[email protected]>
Reviewed-by: Vikram Prakash <[email protected]>
---
drivers/thermal/Kconfig | 3 +-
drivers/thermal/broadcom/Kconfig | 9 ++
drivers/thermal/broadcom/Makefile | 1 +
drivers/thermal/broadcom/sr-thermal.c | 203 ++++++++++++++++++++++++++++++++++
4 files changed, 215 insertions(+), 1 deletion(-)
create mode 100644 drivers/thermal/broadcom/sr-thermal.c
diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index 0e69edc..5f9f070 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -416,7 +416,8 @@ config MTK_THERMAL
controller present in Mediatek SoCs
menu "Broadcom thermal drivers"
-depends on ARCH_BCM || ARCH_BRCMSTB || ARCH_BCM2835 || COMPILE_TEST
+depends on ARCH_BCM || ARCH_BRCMSTB || ARCH_BCM2835 || ARCH_BCM_IPROC || \
+ COMPILE_TEST
source "drivers/thermal/broadcom/Kconfig"
endmenu
diff --git a/drivers/thermal/broadcom/Kconfig b/drivers/thermal/broadcom/Kconfig
index c106a15..dc9a9bd 100644
--- a/drivers/thermal/broadcom/Kconfig
+++ b/drivers/thermal/broadcom/Kconfig
@@ -22,3 +22,12 @@ config BCM_NS_THERMAL
BCM4708, BCM4709, BCM5301x, BCM95852X, etc). It contains DMU (Device
Management Unit) block with a thermal sensor that allows checking CPU
temperature.
+
+config BCM_SR_THERMAL
+ tristate "Stingray thermal driver"
+ depends on ARCH_BCM_IPROC || COMPILE_TEST
+ default ARCH_BCM_IPROC
+ help
+ Support for the Stingray family of SoCs. Its different blocks like
+ iHost, CRMU and NITRO has thermal sensor that allows checking its
+ temperature.
diff --git a/drivers/thermal/broadcom/Makefile b/drivers/thermal/broadcom/Makefile
index fae10ec..79df69e 100644
--- a/drivers/thermal/broadcom/Makefile
+++ b/drivers/thermal/broadcom/Makefile
@@ -1,3 +1,4 @@
obj-$(CONFIG_BCM2835_THERMAL) += bcm2835_thermal.o
obj-$(CONFIG_BRCMSTB_THERMAL) += brcmstb_thermal.o
obj-$(CONFIG_BCM_NS_THERMAL) += ns-thermal.o
+obj-$(CONFIG_BCM_SR_THERMAL) += sr-thermal.o
diff --git a/drivers/thermal/broadcom/sr-thermal.c b/drivers/thermal/broadcom/sr-thermal.c
new file mode 100644
index 0000000..df91055
--- /dev/null
+++ b/drivers/thermal/broadcom/sr-thermal.c
@@ -0,0 +1,203 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2018 Broadcom
+ */
+
+#include <linux/acpi.h>
+#include <linux/module.h>
+#include <linux/of_address.h>
+#include <linux/platform_device.h>
+#include <linux/thermal.h>
+
+/*
+ * In stingray thermal IO memory,
+ * Total Number of available TMONs MASK is at offset 0
+ * temperature registers BASE is at 4 byte offset.
+ * Each TMON temperature register size is 4.
+ */
+#define SR_TMON_TEMP_BASE(id) ((id) * 0x4)
+
+static const char * const sr_tmon_names[] = {
+ "sr_tmon_ihost0",
+ "sr_tmon_ihost1",
+ "sr_tmon_ihost2",
+ "sr_tmon_ihost3",
+ "sr_tmon_crmu",
+ "sr_tmon_nitro",
+};
+
+#define SR_TMON_MAX_LIST ARRAY_SIZE(sr_tmon_names)
+#define MAX_NUMBER_OF_TRIPS 1
+
+struct sr_tmon {
+ struct thermal_zone_device *tz;
+ unsigned int crit_temp;
+ unsigned int tmon_id;
+ struct sr_thermal *priv;
+};
+
+struct sr_thermal {
+ void __iomem *regs;
+ unsigned int max_crit_temp;
+ struct sr_tmon tmon[SR_TMON_MAX_LIST];
+};
+
+static int sr_get_temp(struct thermal_zone_device *tz, int *temp)
+{
+ struct sr_tmon *tmon = tz->devdata;
+ struct sr_thermal *sr_thermal = tmon->priv;
+
+ *temp = readl(sr_thermal->regs + SR_TMON_TEMP_BASE(tmon->tmon_id));
+
+ return 0;
+}
+
+static int sr_get_trip_type(struct thermal_zone_device *tz, int trip,
+ enum thermal_trip_type *type)
+{
+ if (trip >= MAX_NUMBER_OF_TRIPS)
+ return -EINVAL;
+
+ *type = THERMAL_TRIP_CRITICAL;
+
+ return 0;
+}
+
+static int sr_get_trip_temp(struct thermal_zone_device *tz, int trip, int *temp)
+{
+ struct sr_tmon *tmon = tz->devdata;
+
+ if (trip >= MAX_NUMBER_OF_TRIPS)
+ return -EINVAL;
+
+ *temp = tmon->crit_temp;
+
+ return 0;
+}
+
+static int sr_set_trip_temp(struct thermal_zone_device *tz, int trip, int temp)
+{
+ struct sr_tmon *tmon = tz->devdata;
+ struct sr_thermal *sr_thermal = tmon->priv;
+
+ if (trip >= MAX_NUMBER_OF_TRIPS)
+ return -EINVAL;
+
+ if (temp > sr_thermal->max_crit_temp)
+ return -EINVAL;
+
+ tmon->crit_temp = temp;
+
+ return 0;
+}
+
+static struct thermal_zone_device_ops sr_thermal_ops = {
+ .get_temp = sr_get_temp,
+ .get_trip_type = sr_get_trip_type,
+ .get_trip_temp = sr_get_trip_temp,
+ .set_trip_temp = sr_set_trip_temp,
+};
+
+static int sr_thermal_probe(struct platform_device *pdev)
+{
+ struct device *dev = &pdev->dev;
+ struct sr_thermal *sr_thermal;
+ struct sr_tmon *tmon;
+ struct resource *res;
+ uint32_t sr_tmon_list = 0;
+ unsigned int i;
+ int ret;
+
+ sr_thermal = devm_kzalloc(dev, sizeof(*sr_thermal), GFP_KERNEL);
+ if (!sr_thermal)
+ return -ENOMEM;
+
+ res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ sr_thermal->regs = (void __iomem *)devm_memremap(&pdev->dev, res->start,
+ resource_size(res), MEMREMAP_WB);
+ if (IS_ERR(sr_thermal->regs)) {
+ dev_err(dev, "failed to get io address\n");
+ return PTR_ERR(sr_thermal->regs);
+ }
+
+ ret = device_property_read_u32(dev, "brcm,tmon-mask", &sr_tmon_list);
+ if (ret)
+ return ret;
+
+ ret = device_property_read_u32(dev, "brcm,max-crit-temp",
+ &sr_thermal->max_crit_temp);
+ if (ret)
+ return ret;
+
+ tmon = sr_thermal->tmon;
+ for (i = 0; i < SR_TMON_MAX_LIST; i++, tmon++) {
+
+ if (!(sr_tmon_list & BIT(i)))
+ continue;
+
+ /* Flush temperature registers */
+ writel(0, sr_thermal->regs + SR_TMON_TEMP_BASE(i));
+ tmon->crit_temp = sr_thermal->max_crit_temp;
+ tmon->tmon_id = i;
+ tmon->priv = sr_thermal;
+ tmon->tz = thermal_zone_device_register(sr_tmon_names[i],
+ MAX_NUMBER_OF_TRIPS, 1,
+ tmon,
+ &sr_thermal_ops,
+ NULL, 1000, 1000);
+ if (IS_ERR(tmon->tz))
+ goto err_exit;
+
+ dev_info(dev, "%s: registered\n", sr_tmon_names[i]);
+ }
+ platform_set_drvdata(pdev, sr_thermal);
+
+ return 0;
+
+err_exit:
+ while (--i >= 0) {
+ if (sr_thermal->tmon[i].tz)
+ thermal_zone_device_unregister(sr_thermal->tmon[i].tz);
+ }
+
+ return PTR_ERR(tmon->tz);
+}
+
+static int sr_thermal_remove(struct platform_device *pdev)
+{
+ struct sr_thermal *sr_thermal = platform_get_drvdata(pdev);
+ unsigned int i;
+
+ for (i = 0; i < SR_TMON_MAX_LIST; i++)
+ if (sr_thermal->tmon[i].tz)
+ thermal_zone_device_unregister(sr_thermal->tmon[i].tz);
+
+ return 0;
+}
+
+static const struct of_device_id sr_thermal_of_match[] = {
+ { .compatible = "brcm,sr-thermal", },
+ {},
+};
+MODULE_DEVICE_TABLE(of, sr_thermal_of_match);
+
+static const struct acpi_device_id sr_thermal_acpi_ids[] = {
+ { .id = "BRCM0500" },
+ { /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(acpi, sr_thermal_acpi_ids);
+
+static struct platform_driver sr_thermal_driver = {
+ .probe = sr_thermal_probe,
+ .remove = sr_thermal_remove,
+ .driver = {
+ .name = "sr-thermal",
+ .of_match_table = sr_thermal_of_match,
+ .acpi_match_table = ACPI_PTR(sr_thermal_acpi_ids),
+ },
+};
+module_platform_driver(sr_thermal_driver);
+
+MODULE_AUTHOR("Pramod Kumar <[email protected]>");
+MODULE_DESCRIPTION("Stingray thermal driver");
+MODULE_LICENSE("GPL v2");
--
2.7.4
On Thu, Sep 27, 2018 at 09:06:41PM +0530, Srinath Mannam wrote:
> From: Pramod Kumar <[email protected]>
>
> Add binding document for supported thermal implementation
> in Stingray.
>
> Signed-off-by: Pramod Kumar <[email protected]>
> Signed-off-by: Srinath Mannam <[email protected]>
> Reviewed-by: Ray Jui <[email protected]>
> Reviewed-by: Scott Branden <[email protected]>
> ---
> .../bindings/thermal/brcm,sr-thermal.txt | 25 ++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt
>
> diff --git a/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt b/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt
> new file mode 100644
> index 0000000..717617b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt
> @@ -0,0 +1,25 @@
> +* Broadcom Stingray Thermal
> +
> +This binding describes thermal sensors that is part of Stingray SoCs.
> +
> +Required properties:
> +- compatible : Must be "brcm,sr-thermal"
> +- reg : memory where tmon data will be available.
> +- brcm,tmon-mask: A one cell bit mask of valid TMON sources.
> + Each bit represents single TMON source.
> +- brcm,max-crit-temp: Maximum supported critical temperature.
We already have a defined binding for setting trip points.
> +
> +Example:
> + tmons {
> + compatible = "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x0 0x0 0x8f100000 0x100>;
> +
> + tmon: thermal@0 {
> + compatible = "brcm,sr-thermal";
> + reg = <0 0x40>;
> + brcm,tmon-mask = <0x3f>;
> + brcm,max-crit-temp = <105000>;
> + };
> + };
> --
> 2.7.4
>
On 09/27/2018 10:27 AM, Rob Herring wrote:
> On Thu, Sep 27, 2018 at 09:06:41PM +0530, Srinath Mannam wrote:
>> From: Pramod Kumar <[email protected]>
>>
>> Add binding document for supported thermal implementation
>> in Stingray.
>>
>> Signed-off-by: Pramod Kumar <[email protected]>
>> Signed-off-by: Srinath Mannam <[email protected]>
>> Reviewed-by: Ray Jui <[email protected]>
>> Reviewed-by: Scott Branden <[email protected]>
>> ---
>> .../bindings/thermal/brcm,sr-thermal.txt | 25 ++++++++++++++++++++++
>> 1 file changed, 25 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt
>>
>> diff --git a/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt b/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt
>> new file mode 100644
>> index 0000000..717617b
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt
>> @@ -0,0 +1,25 @@
>> +* Broadcom Stingray Thermal
>> +
>> +This binding describes thermal sensors that is part of Stingray SoCs.
>> +
>> +Required properties:
>> +- compatible : Must be "brcm,sr-thermal"
>> +- reg : memory where tmon data will be available.
>> +- brcm,tmon-mask: A one cell bit mask of valid TMON sources.
>> + Each bit represents single TMON source.
>> +- brcm,max-crit-temp: Maximum supported critical temperature.
>
> We already have a defined binding for setting trip points.
Indeed, and if you have multiple TMONs, they would in premise possibly
each have a different critical trip point.
>
>> +
>> +Example:
>> + tmons {
>> + compatible = "simple-bus";
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + ranges = <0x0 0x0 0x8f100000 0x100>;
>> +
>> + tmon: thermal@0 {
>> + compatible = "brcm,sr-thermal";
>> + reg = <0 0x40>;
>> + brcm,tmon-mask = <0x3f>;
>> + brcm,max-crit-temp = <105000>;
>> + };
>> + };
>> --
>> 2.7.4
>>
--
Florian
On 18-09-27 10:31 AM, Florian Fainelli wrote:
> On 09/27/2018 10:27 AM, Rob Herring wrote:
>> On Thu, Sep 27, 2018 at 09:06:41PM +0530, Srinath Mannam wrote:
>>> From: Pramod Kumar <[email protected]>
>>>
>>> Add binding document for supported thermal implementation
>>> in Stingray.
>>>
>>> Signed-off-by: Pramod Kumar <[email protected]>
>>> Signed-off-by: Srinath Mannam <[email protected]>
>>> Reviewed-by: Ray Jui <[email protected]>
>>> Reviewed-by: Scott Branden <[email protected]>
>>> ---
>>> .../bindings/thermal/brcm,sr-thermal.txt | 25 ++++++++++++++++++++++
>>> 1 file changed, 25 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt b/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt
>>> new file mode 100644
>>> index 0000000..717617b
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt
>>> @@ -0,0 +1,25 @@
>>> +* Broadcom Stingray Thermal
>>> +
>>> +This binding describes thermal sensors that is part of Stingray SoCs.
>>> +
>>> +Required properties:
>>> +- compatible : Must be "brcm,sr-thermal"
>>> +- reg : memory where tmon data will be available.
>>> +- brcm,tmon-mask: A one cell bit mask of valid TMON sources.
>>> + Each bit represents single TMON source.
>>> +- brcm,max-crit-temp: Maximum supported critical temperature.
>> We already have a defined binding for setting trip points.
> Indeed, and if you have multiple TMONs, they would in premise possibly
> each have a different critical trip point.
Which may be a good reason to go back to our original bindings which
were generic and had each sensor in its own node?
>>> +
>>> +Example:
>>> + tmons {
>>> + compatible = "simple-bus";
>>> + #address-cells = <1>;
>>> + #size-cells = <1>;
>>> + ranges = <0x0 0x0 0x8f100000 0x100>;
>>> +
>>> + tmon: thermal@0 {
>>> + compatible = "brcm,sr-thermal";
>>> + reg = <0 0x40>;
>>> + brcm,tmon-mask = <0x3f>;
>>> + brcm,max-crit-temp = <105000>;
>>> + };
>>> + };
>>> --
>>> 2.7.4
>>>
>
On Thu, Sep 27, 2018 at 11:00:33AM -0700, Scott Branden wrote:
>
>
> On 18-09-27 10:31 AM, Florian Fainelli wrote:
> > On 09/27/2018 10:27 AM, Rob Herring wrote:
> > > On Thu, Sep 27, 2018 at 09:06:41PM +0530, Srinath Mannam wrote:
> > > > From: Pramod Kumar <[email protected]>
> > > >
> > > > Add binding document for supported thermal implementation
> > > > in Stingray.
> > > >
> > > > Signed-off-by: Pramod Kumar <[email protected]>
> > > > Signed-off-by: Srinath Mannam <[email protected]>
> > > > Reviewed-by: Ray Jui <[email protected]>
> > > > Reviewed-by: Scott Branden <[email protected]>
> > > > ---
> > > > .../bindings/thermal/brcm,sr-thermal.txt | 25 ++++++++++++++++++++++
> > > > 1 file changed, 25 insertions(+)
> > > > create mode 100644 Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt b/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt
> > > > new file mode 100644
> > > > index 0000000..717617b
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt
> > > > @@ -0,0 +1,25 @@
> > > > +* Broadcom Stingray Thermal
> > > > +
> > > > +This binding describes thermal sensors that is part of Stingray SoCs.
> > > > +
> > > > +Required properties:
> > > > +- compatible : Must be "brcm,sr-thermal"
> > > > +- reg : memory where tmon data will be available.
> > > > +- brcm,tmon-mask: A one cell bit mask of valid TMON sources.
> > > > + Each bit represents single TMON source.
> > > > +- brcm,max-crit-temp: Maximum supported critical temperature.
> > > We already have a defined binding for setting trip points.
> > Indeed, and if you have multiple TMONs, they would in premise possibly
> > each have a different critical trip point.
> Which may be a good reason to go back to our original bindings which were
> generic and had each sensor in its own node?
Perhaps. I wouldn't call it going back to your original, but rather
defining a complete binding. Of course, if you don't need different trip
points, then again that is just unnecessary bloat. But I can't argue
whether you do or don't.
Rob
On 18-09-27 11:59 AM, Rob Herring wrote:
> On Thu, Sep 27, 2018 at 11:00:33AM -0700, Scott Branden wrote:
>>
>> On 18-09-27 10:31 AM, Florian Fainelli wrote:
>>> On 09/27/2018 10:27 AM, Rob Herring wrote:
>>>> On Thu, Sep 27, 2018 at 09:06:41PM +0530, Srinath Mannam wrote:
>>>>> From: Pramod Kumar <[email protected]>
>>>>>
>>>>> Add binding document for supported thermal implementation
>>>>> in Stingray.
>>>>>
>>>>> Signed-off-by: Pramod Kumar <[email protected]>
>>>>> Signed-off-by: Srinath Mannam <[email protected]>
>>>>> Reviewed-by: Ray Jui <[email protected]>
>>>>> Reviewed-by: Scott Branden <[email protected]>
>>>>> ---
>>>>> .../bindings/thermal/brcm,sr-thermal.txt | 25 ++++++++++++++++++++++
>>>>> 1 file changed, 25 insertions(+)
>>>>> create mode 100644 Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt b/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt
>>>>> new file mode 100644
>>>>> index 0000000..717617b
>>>>> --- /dev/null
>>>>> +++ b/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt
>>>>> @@ -0,0 +1,25 @@
>>>>> +* Broadcom Stingray Thermal
>>>>> +
>>>>> +This binding describes thermal sensors that is part of Stingray SoCs.
>>>>> +
>>>>> +Required properties:
>>>>> +- compatible : Must be "brcm,sr-thermal"
>>>>> +- reg : memory where tmon data will be available.
>>>>> +- brcm,tmon-mask: A one cell bit mask of valid TMON sources.
>>>>> + Each bit represents single TMON source.
>>>>> +- brcm,max-crit-temp: Maximum supported critical temperature.
>>>> We already have a defined binding for setting trip points.
>>> Indeed, and if you have multiple TMONs, they would in premise possibly
>>> each have a different critical trip point.
>> Which may be a good reason to go back to our original bindings which were
>> generic and had each sensor in its own node?
> Perhaps. I wouldn't call it going back to your original, but rather
> defining a complete binding. Of course, if you don't need different trip
> points, then again that is just unnecessary bloat. But I can't argue
> whether you do or don't.
We currently do not need different trip points as detailed analysis of
each sensor's trip point has not been needed. If we do add different
trip points per sensor the node per sensor approach looks very
flexible. Call it what you like: Srinath's original driver.
>
> Rob