this series adds the sw_machine_cover key, and changes the nokia n900 dts to
expose the key via gpio-keys.
before, this gpio was used as card detect gpio, causing the card not to show up
if the phone was booted without cover, see this thread on linux-omap:
n900: remove mmc1 "safety feature"? (was: re: mmc0 on nokia n900 on linux 5.4.18)
since there is no realistic use for using this gpio as card detect, instead
expose it to userspace via gpio-keys. there are no event type for machine covers
yet, so add that first.
the key should be 1 when the cover is closed, and 0 when the cover is open.
starting the nokia n900 with the cover removed, putting the cover in place:
event: time 1581684523.415296, type 5 (ev_sw), code 16 (?), value 1
removing the cover again, exposing mmc1 and the battery:
event: time 1581684529.413706, type 5 (ev_sw), code 16 (?), value 0
Merlijn Wajer (2):
Input: add `SW_MACHINE_COVER`
ARM: dts: n900: remove mmc1 card detect gpio
arch/arm/boot/dts/omap3-n900.dts | 12 ++++++++----
include/linux/mod_devicetable.h | 2 +-
include/uapi/linux/input-event-codes.h | 3 ++-
3 files changed, 11 insertions(+), 6 deletions(-)
--
2.23.0
This event code represents the state of a removable cover of a device.
Value 0 means that the cover is open or removed, value 1 means that the
cover is closed.
Reviewed-by: Sebastian Reichel <[email protected]>
Signed-off-by: Merlijn Wajer <[email protected]>
---
include/linux/mod_devicetable.h | 2 +-
include/uapi/linux/input-event-codes.h | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h
index 448621c32e4d..4c692cb3cc1d 100644
--- a/include/linux/mod_devicetable.h
+++ b/include/linux/mod_devicetable.h
@@ -299,7 +299,7 @@ struct pcmcia_device_id {
#define INPUT_DEVICE_ID_LED_MAX 0x0f
#define INPUT_DEVICE_ID_SND_MAX 0x07
#define INPUT_DEVICE_ID_FF_MAX 0x7f
-#define INPUT_DEVICE_ID_SW_MAX 0x0f
+#define INPUT_DEVICE_ID_SW_MAX 0x10
#define INPUT_DEVICE_ID_PROP_MAX 0x1f
#define INPUT_DEVICE_ID_MATCH_BUS 1
diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
index 64cee116928e..68f8ad8377a1 100644
--- a/include/uapi/linux/input-event-codes.h
+++ b/include/uapi/linux/input-event-codes.h
@@ -807,7 +807,8 @@
#define SW_LINEIN_INSERT 0x0d /* set = inserted */
#define SW_MUTE_DEVICE 0x0e /* set = device disabled */
#define SW_PEN_INSERTED 0x0f /* set = pen inserted */
-#define SW_MAX 0x0f
+#define SW_MACHINE_COVER 0x10 /* set = cover closed */
+#define SW_MAX 0x10
#define SW_CNT (SW_MAX+1)
/*
--
2.23.0
* Merlijn Wajer <[email protected]> [200215 09:01]:
> this series adds the sw_machine_cover key, and changes the nokia n900 dts to
> expose the key via gpio-keys.
Looks good to me. It's probably best to apply these via the input subsystem
tree because of the generci SW_MACHINE_COVER key addition. For both patches:
Acked-by: Tony Lindgren <[email protected]>
Hi,
Any objections or further comments on these two patches? It's been a while.
Cheers,
Merlijn
On 15/02/2020 18:02, Merlijn Wajer wrote:
> this series adds the sw_machine_cover key, and changes the nokia n900 dts to
> expose the key via gpio-keys.
>
> before, this gpio was used as card detect gpio, causing the card not to show up
> if the phone was booted without cover, see this thread on linux-omap:
>
> n900: remove mmc1 "safety feature"? (was: re: mmc0 on nokia n900 on linux 5.4.18)
>
> since there is no realistic use for using this gpio as card detect, instead
> expose it to userspace via gpio-keys. there are no event type for machine covers
> yet, so add that first.
>
> the key should be 1 when the cover is closed, and 0 when the cover is open.
>
> starting the nokia n900 with the cover removed, putting the cover in place:
>
> event: time 1581684523.415296, type 5 (ev_sw), code 16 (?), value 1
>
> removing the cover again, exposing mmc1 and the battery:
>
> event: time 1581684529.413706, type 5 (ev_sw), code 16 (?), value 0
>
> Merlijn Wajer (2):
> Input: add `SW_MACHINE_COVER`
> ARM: dts: n900: remove mmc1 card detect gpio
>
> arch/arm/boot/dts/omap3-n900.dts | 12 ++++++++----
> include/linux/mod_devicetable.h | 2 +-
> include/uapi/linux/input-event-codes.h | 3 ++-
> 3 files changed, 11 insertions(+), 6 deletions(-)
>
Hi,
A while later (again) - any thoughts/comments?
Should I resend the series?
Thanks,
Merlijn
On 15/04/2020 15:29, Merlijn Wajer wrote:
> Hi,
>
> Any objections or further comments on these two patches? It's been a while.
>
> Cheers,
> Merlijn
>
> On 15/02/2020 18:02, Merlijn Wajer wrote:
>> this series adds the sw_machine_cover key, and changes the nokia n900 dts to
>> expose the key via gpio-keys.
>>
>> before, this gpio was used as card detect gpio, causing the card not to show up
>> if the phone was booted without cover, see this thread on linux-omap:
>>
>> n900: remove mmc1 "safety feature"? (was: re: mmc0 on nokia n900 on linux 5.4.18)
>>
>> since there is no realistic use for using this gpio as card detect, instead
>> expose it to userspace via gpio-keys. there are no event type for machine covers
>> yet, so add that first.
>>
>> the key should be 1 when the cover is closed, and 0 when the cover is open.
>>
>> starting the nokia n900 with the cover removed, putting the cover in place:
>>
>> event: time 1581684523.415296, type 5 (ev_sw), code 16 (?), value 1
>>
>> removing the cover again, exposing mmc1 and the battery:
>>
>> event: time 1581684529.413706, type 5 (ev_sw), code 16 (?), value 0
>>
>> Merlijn Wajer (2):
>> Input: add `SW_MACHINE_COVER`
>> ARM: dts: n900: remove mmc1 card detect gpio
>>
>> arch/arm/boot/dts/omap3-n900.dts | 12 ++++++++----
>> include/linux/mod_devicetable.h | 2 +-
>> include/uapi/linux/input-event-codes.h | 3 ++-
>> 3 files changed, 11 insertions(+), 6 deletions(-)
>>
>
>
Hi!
> A while later (again) - any thoughts/comments?
>
> Should I resend the series?
Sorry, I did not see this before. Can you cc me on the next patch
iteration?
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html