2018-11-13 06:36:19

by Adeodato Simó

Subject: [PATCH] net/9p: include trans_common.h to fix missing prototype warning.

This silences -Wmissing-prototypes when defining p9_release_pages.

Signed-off-by: Adeodato Simó <[email protected]>
---
net/9p/trans_common.c | 1 +
1 file changed, 1 insertion(+)

It was suggested in the kernel-janitors mailing list that silencing
-Wmissing-prototypes would make for a worthy cause.

https://www.spinics.net/lists/linux-kernel-janitors/msg43981.html

Resending w/ Cc: linux-kernel as requested by Dominique.

diff --git a/net/9p/trans_common.c b/net/9p/trans_common.c
index b718db2085b2..3dff68f05fb9 100644
--- a/net/9p/trans_common.c
+++ b/net/9p/trans_common.c
@@ -14,6 +14,7 @@

#include <linux/mm.h>
#include <linux/module.h>
+#include "trans_common.h"

/**
* p9_release_pages - Release pages after the transaction.
--
2.19.1

2018-11-13 13:09:47

by Dominique Martinet

Subject: Re: [PATCH] net/9p: include trans_common.h to fix missing prototype warning.

Adeodato Simó wrote on Tue, Nov 13, 2018:
> This silences -Wmissing-prototypes when defining p9_release_pages.
>
> Signed-off-by: Adeodato Simó <[email protected]>
> ---
> net/9p/trans_common.c | 1 +
> 1 file changed, 1 insertion(+)
>
> It was suggested in the kernel-janitors mailing list that silencing
> -Wmissing-prototypes would make for a worthy cause.
>
> https://www.spinics.net/lists/linux-kernel-janitors/msg43981.html
>
> Resending w/ Cc: linux-kernel as requested by Dominique.

Great, pushed to my for-next branch, it'll probably get in there today
or tomorrow.

Thanks!
--
Dominique