Update the Aspeed PECI driver with the AST2600 compatible string.
A new comptabile string is needed for the extended HW feature of
AST2600.
Chia-Wei, Wang (2):
peci: aspeed: Add AST2600 compatible string
dt-bindings: peci: aspeed: Add AST2600 compatible
Documentation/devicetree/bindings/peci/peci-aspeed.txt | 1 +
drivers/peci/peci-aspeed.c | 1 +
2 files changed, 2 insertions(+)
--
2.17.1
The AST2600 SoC contains the same register set as AST25xx.
Signed-off-by: Chia-Wei, Wang <[email protected]>
---
drivers/peci/peci-aspeed.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/peci/peci-aspeed.c b/drivers/peci/peci-aspeed.c
index 51cb2563ceb6..4eed119dc83b 100644
--- a/drivers/peci/peci-aspeed.c
+++ b/drivers/peci/peci-aspeed.c
@@ -485,6 +485,7 @@ static int aspeed_peci_remove(struct platform_device *pdev)
static const struct of_device_id aspeed_peci_of_table[] = {
{ .compatible = "aspeed,ast2400-peci", },
{ .compatible = "aspeed,ast2500-peci", },
+ { .compatible = "aspeed,ast2600-peci", },
{ }
};
MODULE_DEVICE_TABLE(of, aspeed_peci_of_table);
--
2.17.1
Hi Chia-Wei,
On 10/1/2019 11:11 PM, Chia-Wei, Wang wrote:
> Update the Aspeed PECI driver with the AST2600 compatible string.
> A new comptabile string is needed for the extended HW feature of
> AST2600.
>
> Chia-Wei, Wang (2):
> peci: aspeed: Add AST2600 compatible string
> dt-bindings: peci: aspeed: Add AST2600 compatible
>
> Documentation/devicetree/bindings/peci/peci-aspeed.txt | 1 +
> drivers/peci/peci-aspeed.c | 1 +
> 2 files changed, 2 insertions(+)
>
PECI subsystem isn't in linux upstream yet so you should submit it into
OpenBMC dev-5.3 tree only.
Cheers,
Jae
On Wed, 2 Oct 2019 at 18:11, Jae Hyun Yoo <[email protected]> wrote:
>
> Hi Chia-Wei,
>
> On 10/1/2019 11:11 PM, Chia-Wei, Wang wrote:
> > Update the Aspeed PECI driver with the AST2600 compatible string.
> > A new comptabile string is needed for the extended HW feature of
> > AST2600.
> >
> > Chia-Wei, Wang (2):
> > peci: aspeed: Add AST2600 compatible string
> > dt-bindings: peci: aspeed: Add AST2600 compatible
> >
> > Documentation/devicetree/bindings/peci/peci-aspeed.txt | 1 +
> > drivers/peci/peci-aspeed.c | 1 +
> > 2 files changed, 2 insertions(+)
> >
>
> PECI subsystem isn't in linux upstream yet so you should submit it into
> OpenBMC dev-5.3 tree only.
OpenBMC has been carrying the out of tree patches for some time now. I
haven't seen a new version posted for a while. Do you have a timeline
for when you plan to submit it upstream?
On 10/2/2019 3:05 PM, Joel Stanley wrote:
> On Wed, 2 Oct 2019 at 18:11, Jae Hyun Yoo <[email protected]> wrote:
>>
>> Hi Chia-Wei,
>>
>> On 10/1/2019 11:11 PM, Chia-Wei, Wang wrote:
>>> Update the Aspeed PECI driver with the AST2600 compatible string.
>>> A new comptabile string is needed for the extended HW feature of
>>> AST2600.
>>>
>>> Chia-Wei, Wang (2):
>>> peci: aspeed: Add AST2600 compatible string
>>> dt-bindings: peci: aspeed: Add AST2600 compatible
>>>
>>> Documentation/devicetree/bindings/peci/peci-aspeed.txt | 1 +
>>> drivers/peci/peci-aspeed.c | 1 +
>>> 2 files changed, 2 insertions(+)
>>>
>>
>> PECI subsystem isn't in linux upstream yet so you should submit it into
>> OpenBMC dev-5.3 tree only.
>
> OpenBMC has been carrying the out of tree patches for some time now. I
> haven't seen a new version posted for a while. Do you have a timeline
> for when you plan to submit it upstream?
Thanks for your effort for carrying the out of tree patches in OpenBMC.
I don't have a exact timeline but I'm gonna upstream it as soon as it
gets ready.
Thanks,
Jae
Hi Jae Hyun,
Thanks for the feedback.
For now should I use GitHub pull-request to submit the patches of PECI-related change to OpenBMC dev-5.3 tree only?
Regards,
Chiawei
************* Email Confidentiality Notice ********************
DISCLAIMER:
This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you.
-----Original Message-----
From: Jae Hyun Yoo [mailto:[email protected]]
Sent: Thursday, October 3, 2019 7:43 AM
To: Joel Stanley <[email protected]>
Cc: ChiaWei Wang <[email protected]>; Jason M Biils <[email protected]>; Rob Herring <[email protected]>; Mark Rutland <[email protected]>; Andrew Jeffery <[email protected]>; linux-aspeed <[email protected]>; OpenBMC Maillist <[email protected]>; devicetree <[email protected]>; Linux ARM <[email protected]>; Linux Kernel Mailing List <[email protected]>; Ryan Chen <[email protected]>
Subject: Re: [PATCH 0/2] peci: aspeed: Add AST2600 compatible
On 10/2/2019 3:05 PM, Joel Stanley wrote:
> On Wed, 2 Oct 2019 at 18:11, Jae Hyun Yoo <[email protected]> wrote:
>>
>> Hi Chia-Wei,
>>
>> On 10/1/2019 11:11 PM, Chia-Wei, Wang wrote:
>>> Update the Aspeed PECI driver with the AST2600 compatible string.
>>> A new comptabile string is needed for the extended HW feature of
>>> AST2600.
>>>
>>> Chia-Wei, Wang (2):
>>> peci: aspeed: Add AST2600 compatible string
>>> dt-bindings: peci: aspeed: Add AST2600 compatible
>>>
>>> Documentation/devicetree/bindings/peci/peci-aspeed.txt | 1 +
>>> drivers/peci/peci-aspeed.c | 1 +
>>> 2 files changed, 2 insertions(+)
>>>
>>
>> PECI subsystem isn't in linux upstream yet so you should submit it
>> into OpenBMC dev-5.3 tree only.
>
> OpenBMC has been carrying the out of tree patches for some time now. I
> haven't seen a new version posted for a while. Do you have a timeline
> for when you plan to submit it upstream?
Thanks for your effort for carrying the out of tree patches in OpenBMC.
I don't have a exact timeline but I'm gonna upstream it as soon as it gets ready.
Thanks,
Jae
On 10/2/2019 7:35 PM, ChiaWei Wang wrote:
> Hi Jae Hyun,
>
> Thanks for the feedback.
> For now should I use GitHub pull-request to submit the patches of PECI-related change to OpenBMC dev-5.3 tree only?
You could submit this patch series to OpenBMC mailing list with
[PATCH linux dev-5.3] prefix.
Thanks,
Jae
Sure. We will re-submit the patches with the revision suggested.
Thanks.
Regards,
Chiawei
************* Email Confidentiality Notice ********************
DISCLAIMER:
This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you.
-----Original Message-----
From: Jae Hyun Yoo [mailto:[email protected]]
Sent: Friday, October 4, 2019 12:20 AM
To: ChiaWei Wang <[email protected]>; Joel Stanley <[email protected]>
Cc: Jason M Biils <[email protected]>; Rob Herring <[email protected]>; Mark Rutland <[email protected]>; Andrew Jeffery <[email protected]>; linux-aspeed <[email protected]>; OpenBMC Maillist <[email protected]>; devicetree <[email protected]>; Linux ARM <[email protected]>; Linux Kernel Mailing List <[email protected]>; Ryan Chen <[email protected]>
Subject: Re: [PATCH 0/2] peci: aspeed: Add AST2600 compatible
On 10/2/2019 7:35 PM, ChiaWei Wang wrote:
> Hi Jae Hyun,
>
> Thanks for the feedback.
> For now should I use GitHub pull-request to submit the patches of PECI-related change to OpenBMC dev-5.3 tree only?
You could submit this patch series to OpenBMC mailing list with [PATCH linux dev-5.3] prefix.
Thanks,
Jae