2020-08-16 13:54:52

by Piyush Thange

Subject: checkpatch.pl- Cleared some white spaces which generated warnings and errors.

commit eb027935d819a3160404f05633ae47f8b8a061c8
Author: Piyush Thange <[email protected]>
AuthorDate: Sun Aug 16 17:52:26 2020 +0530
Commit: Piyush Thange <[email protected]>
CommitDate: Sun Aug 16 17:52:26 2020 +0530

scripts:checkpatch.pl:Cleared the white spaces and errors occured
due to them.

I've removed the white spaced on the line 498, which generated
warning and
errors presented by checkpatch.pl.
Please provide review.

Signed-off-by: Piyush Thange <[email protected]>

Signed-off-by: Piyush Thange <[email protected]>
---
scripts/checkpatch.pl | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 2cbeae6d9aee..fa991a912d9b 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -488,17 +488,7 @@ our $allocFunctions = qr{(?x:
dma_alloc_coherent
)};

-our $signature_tags = qr{(?xi:
- Signed-off-by:|
- Co-developed-by:|
- Acked-by:|
- Tested-by:|
- Reviewed-by:|
- Reported-by:|
- Suggested-by:|
- To:|
- Cc:
-)};
+our $signature_tags =
qr{(?xi:Signed-off-by:|Co-developed-by:|Acked-by:|Tested-by:|Reviewed-by:|Reported-by:|Suggested-by:|To:|Cc:)};

our @typeListMisordered = (
qr{char\s+(?:un)?signed},
--
2.25.1

2020-08-16 16:20:51

by Joe Perches

Subject: Re: checkpatch.pl- Cleared some white spaces which generated warnings and errors.

On Sun, 2020-08-16 at 18:25 +0530, Piyush Thange wrote:
> commit eb027935d819a3160404f05633ae47f8b8a061c8
[]
> scripts:checkpatch.pl:Cleared the white spaces and errors occured
> due to them.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -488,17 +488,7 @@ our $allocFunctions = qr{(?x:
> dma_alloc_coherent
> )};
>
> -our $signature_tags = qr{(?xi:
> - Signed-off-by:|
> - Co-developed-by:|
> - Acked-by:|
> - Tested-by:|
> - Reviewed-by:|
> - Reported-by:|
> - Suggested-by:|
> - To:|
> - Cc:
> -)};
> +our $signature_tags =
> qr{(?xi:Signed-off-by:|Co-developed-by:|Acked-by:|Tested-by:|Reviewed-by:|Reported-by:|Suggested-by:|To:|Cc:)};

Do you think this is more readable now?
No thanks.