2024-04-30 21:29:44

by Allen Ballway

[permalink] [raw]
Subject: [PATCH] ALSA: hda: intel-dsp-config: Fix Azulle Access 4 quirk detection

This device has an audio card which is quirked for force SOF use but the
device does not support SOF so the card is not usable and audio can't
play through the HDMI output.

Add another quirk detection that matches the Azulle Access 4 in the DMI
info.

Signed-off-by: Allen Ballway <[email protected]>
---

sound/hda/intel-dsp-config.c | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/sound/hda/intel-dsp-config.c b/sound/hda/intel-dsp-config.c
index 6a384b922e4fa..cf4e25d031d56 100644
--- a/sound/hda/intel-dsp-config.c
+++ b/sound/hda/intel-dsp-config.c
@@ -142,7 +142,9 @@ static const struct config_entry config_table[] = {

/*
* Geminilake uses legacy HDAudio driver except for Google
- * Chromebooks and devices based on the ES8336 codec
+ * Chromebooks and devices based on the ES8336 codec. The Azulle Access 4
+ * uses the same audio card but does not support ES8336 and should use
+ * the legacy HDAudio driver.
*/
/* Geminilake */
#if IS_ENABLED(CONFIG_SND_SOC_SOF_GEMINILAKE)
@@ -159,6 +161,20 @@ static const struct config_entry config_table[] = {
{}
}
},
+ {
+ .flags = 0,
+ .device = PCI_DEVICE_ID_INTEL_HDA_GML,
+ .dmi_table = (const struct dmi_system_id []) {
+ {
+ .ident = "Azulle Access 4",
+ .matches = {
+ DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Azulle"),
+ DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Access4"),
+ }
+ },
+ {}
+ }
+ },
{
.flags = FLAG_SOF,
.device = PCI_DEVICE_ID_INTEL_HDA_GML,
--
2.45.0.rc0.197.gbae5840b3b-goog



2024-05-01 00:51:43

by Pierre-Louis Bossart

[permalink] [raw]
Subject: Re: [PATCH] ALSA: hda: intel-dsp-config: Fix Azulle Access 4 quirk detection



On 4/30/24 16:28, Allen Ballway wrote:
> This device has an audio card which is quirked for force SOF use but the
> device does not support SOF so the card is not usable and audio can't
> play through the HDMI output.
>
> Add another quirk detection that matches the Azulle Access 4 in the DMI
> info.

Please try the patch "ALSA: hda: intel-dsp-config: harden I2C/I2S codec
detection" shared last week.

https://lore.kernel.org/linux-sound/[email protected]/

I really don't want to maintain a long list of ES8336 false detections
due to broken ACPI tables.

Thanks!




2024-05-06 16:40:07

by Allen Ballway

[permalink] [raw]
Subject: Re: [PATCH] ALSA: hda: intel-dsp-config: Fix Azulle Access 4 quirk detection

On Tue, Apr 30, 2024 at 2:46 PM Pierre-Louis Bossart
<[email protected]> wrote:
>
>
>
> On 4/30/24 16:28, Allen Ballway wrote:
> > This device has an audio card which is quirked for force SOF use but the
> > device does not support SOF so the card is not usable and audio can't
> > play through the HDMI output.
> >
> > Add another quirk detection that matches the Azulle Access 4 in the DMI
> > info.
>
> Please try the patch "ALSA: hda: intel-dsp-config: harden I2C/I2S codec
> detection" shared last week.
>
> https://lore.kernel.org/linux-sound/[email protected]/
>
> I really don't want to maintain a long list of ES8336 false detections
> due to broken ACPI tables.
>
> Thanks!

Unfortunately the above patch didn't fix the issue, nor did I see any
of the change logs in dmesg.
Are there other alternative solutions or information I could gather to
make a more general solution?

Thanks,
Allen

2024-05-06 18:03:39

by Pierre-Louis Bossart

[permalink] [raw]
Subject: Re: [PATCH] ALSA: hda: intel-dsp-config: Fix Azulle Access 4 quirk detection




> Unfortunately the above patch didn't fix the issue, nor did I see any
> of the change logs in dmesg.
> Are there other alternative solutions or information I could gather to
> make a more general solution?

File an issue here: https://github.com/thesofproject/linux/issues

and attach the NHLT table:

sudo cat /sys/firmware/acpi/tables/NHLT > nhtl.dat; gzip nhlt.dat

as well as the results of alsa-info.