2023-11-27 16:39:49

by Sergey Shtylyov

Subject: Re: [PATCH 1/6] net: ravb: Check return value of reset_control_deassert()

On 11/27/23 12:04 PM, Claudiu wrote:

> From: Claudiu Beznea <[email protected]>
>
> reset_control_deassert() could return an error. Some devices cannot work
> if reset signal de-assert operation fails.

Well, I think all devices can't work if the reset line is connected at all. :-)

> To avoid this check the return
> code of reset_control_deassert() in ravb_probe() and take proper action.

I'd also mention moving of the free_nedev() call...

> Fixes: 0d13a1a464a0 ("ravb: Add reset support")
> Signed-off-by: Claudiu Beznea <[email protected]>

Reviewed-by: Sergey Shtylyov <[email protected]>

[...]

MBR, Sergey

2023-11-30 07:07:23

by claudiu beznea

Subject: Re: [PATCH 1/6] net: ravb: Check return value of reset_control_deassert()

On 27.11.2023 18:39, Sergey Shtylyov wrote:
> On 11/27/23 12:04 PM, Claudiu wrote:
>
>> From: Claudiu Beznea <[email protected]>
>>
>> reset_control_deassert() could return an error. Some devices cannot work
>> if reset signal de-assert operation fails.
>
> Well, I think all devices can't work if the reset line is connected at all. :-)

I was thinking at the fact that the de-assert support was added just 2
years ago, while the driver seems to be ~8 years old.

>
>> To avoid this check the return
>> code of reset_control_deassert() in ravb_probe() and take proper action.
>
> I'd also mention moving of the free_nedev() call...

ok

>
>> Fixes: 0d13a1a464a0 ("ravb: Add reset support")
>> Signed-off-by: Claudiu Beznea <[email protected]>
>
> Reviewed-by: Sergey Shtylyov <[email protected]>
>
> [...]
>
> MBR, Sergey