2023-08-21 04:26:46

by Yang Jihong

Subject: [PATCH v6 6/7] perf test: Add test case for record sideband events

Add a new test case to record sideband events for all CPUs when tracing
selected CPUs

Test result:

# ./perf test list 2>&1 | grep 'perf record sideband tests'
95: perf record sideband tests
# ./perf test 95
95: perf record sideband tests : Ok

Signed-off-by: Yang Jihong <[email protected]>
Tested-by: Adrian Hunter <[email protected]>
---
tools/perf/tests/shell/record_sideband.sh | 44 +++++++++++++++++++++++
1 file changed, 44 insertions(+)
create mode 100755 tools/perf/tests/shell/record_sideband.sh

diff --git a/tools/perf/tests/shell/record_sideband.sh b/tools/perf/tests/shell/record_sideband.sh
new file mode 100755
index 000000000000..2ecf00011cb1
--- /dev/null
+++ b/tools/perf/tests/shell/record_sideband.sh
@@ -0,0 +1,44 @@
+#!/bin/sh
+# perf record sideband tests
+# SPDX-License-Identifier: GPL-2.0
+
+set -e
+
+err=0
+perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX)
+
+can_cpu_wide()
+{
+ if ! perf record -o ${perfdata} -BN --no-bpf-event -C $1 true 2>&1 >/dev/null
+ then
+ echo "record sideband test [Skipped cannot record cpu$1]"
+ err=2
+ fi
+
+ rm -f ${perfdata}
+ return $err
+}
+
+test_system_wide_tracking()
+{
+ # Need CPU 0 and CPU 1
+ can_cpu_wide 0 || return 0
+ can_cpu_wide 1 || return 0
+
+ # Record on CPU 0 a task running on CPU 1
+ perf record -BN --no-bpf-event -o ${perfdata} -C 0 -- taskset --cpu-list 1 true
+
+ # Should get MMAP events from CPU 1
+ mmap_cnt=`perf script -i ${perfdata} --show-mmap-events -C 1 2>/dev/null | grep MMAP | wc -l`
+
+ rm -f ${perfdata}
+
+ if [ ${mmap_cnt} -gt 0 ] ; then
+ return 0
+ fi
+
+ echo "Failed to record MMAP events on CPU 1 when tracing CPU 0"
+ return 1
+}
+
+test_system_wide_tracking
--
2.30.GIT

2023-08-25 07:19:42

by Yang Jihong

Subject: Re: [PATCH v6 6/7] perf test: Add test case for record sideband events

Hello,

On 2023/8/25 13:28, Ian Rogers wrote:
> On Sun, Aug 20, 2023 at 6:30 PM Yang Jihong <[email protected]> wrote:
>>
>> Add a new test case to record sideband events for all CPUs when tracing
>> selected CPUs
>>
>> Test result:
>>
>> # ./perf test list 2>&1 | grep 'perf record sideband tests'
>> 95: perf record sideband tests
>> # ./perf test 95
>> 95: perf record sideband tests : Ok
>>
>> Signed-off-by: Yang Jihong <[email protected]>
>> Tested-by: Adrian Hunter <[email protected]>
>> ---
>> tools/perf/tests/shell/record_sideband.sh | 44 +++++++++++++++++++++++
>> 1 file changed, 44 insertions(+)
>> create mode 100755 tools/perf/tests/shell/record_sideband.sh
>>
>> diff --git a/tools/perf/tests/shell/record_sideband.sh b/tools/perf/tests/shell/record_sideband.sh
>> new file mode 100755
>> index 000000000000..2ecf00011cb1
>> --- /dev/null
>> +++ b/tools/perf/tests/shell/record_sideband.sh
>> @@ -0,0 +1,44 @@
>> +#!/bin/sh
>> +# perf record sideband tests
>> +# SPDX-License-Identifier: GPL-2.0
>> +
>> +set -e
>> +
>> +err=0
>> +perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX)
>
> Could you add some kind of cleanup on trap function like:
> https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/tests/shell/record.sh?h=perf-tools-next#n26
> It'd be okay to do this as a follow up patch.
>
Okay, it'll be modified in the next version.

Thanks,
Yang