Since commit 71b77a7a27a3 ("enetc: Migrate to PHYLINK and PCS_LYNX") the
network port of the Kontron sl28 board is broken. After the migration to
phylink the device tree has to specify the in-band-mode property. Add
it.
Fixes: 71b77a7a27a3 ("enetc: Migrate to PHYLINK and PCS_LYNX")
Suggested-by: Vladimir Oltean <[email protected]>
Signed-off-by: Michael Walle <[email protected]>
---
arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
index f46eb47cfa4d..8161dd237971 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
@@ -75,6 +75,7 @@
&enetc_port0 {
phy-handle = <&phy0>;
phy-connection-type = "sgmii";
+ managed = "in-band-status";
status = "okay";
mdio {
--
2.20.1
[+Ioana; the reference commit has a typo in her email address]
Am 2020-11-01 14:19, schrieb Michael Walle:
> Since commit 71b77a7a27a3 ("enetc: Migrate to PHYLINK and PCS_LYNX")
> the
> network port of the Kontron sl28 board is broken. After the migration
> to
> phylink the device tree has to specify the in-band-mode property. Add
> it.
>
> Fixes: 71b77a7a27a3 ("enetc: Migrate to PHYLINK and PCS_LYNX")
> Suggested-by: Vladimir Oltean <[email protected]>
> Signed-off-by: Michael Walle <[email protected]>
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
> a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> index f46eb47cfa4d..8161dd237971 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> @@ -75,6 +75,7 @@
> &enetc_port0 {
> phy-handle = <&phy0>;
> phy-connection-type = "sgmii";
> + managed = "in-band-status";
> status = "okay";
>
> mdio {
--
-michael
On Sun, Nov 01, 2020 at 02:19:05PM +0100, Michael Walle wrote:
> Since commit 71b77a7a27a3 ("enetc: Migrate to PHYLINK and PCS_LYNX") the
> network port of the Kontron sl28 board is broken. After the migration to
> phylink the device tree has to specify the in-band-mode property. Add
> it.
>
> Fixes: 71b77a7a27a3 ("enetc: Migrate to PHYLINK and PCS_LYNX")
> Suggested-by: Vladimir Oltean <[email protected]>
> Signed-off-by: Michael Walle <[email protected]>
> ---
Reviewed-by: Vladimir Oltean <[email protected]>
> arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> index f46eb47cfa4d..8161dd237971 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> @@ -75,6 +75,7 @@
> &enetc_port0 {
> phy-handle = <&phy0>;
> phy-connection-type = "sgmii";
> + managed = "in-band-status";
> status = "okay";
>
> mdio {
> --
> 2.20.1
>
Hi,
Am 2020-11-01 14:19, schrieb Michael Walle:
> Since commit 71b77a7a27a3 ("enetc: Migrate to PHYLINK and PCS_LYNX")
> the
> network port of the Kontron sl28 board is broken. After the migration
> to
> phylink the device tree has to specify the in-band-mode property. Add
> it.
>
> Fixes: 71b77a7a27a3 ("enetc: Migrate to PHYLINK and PCS_LYNX")
> Suggested-by: Vladimir Oltean <[email protected]>
> Signed-off-by: Michael Walle <[email protected]>
Ping. will this go through the net queue or Shawn's queue. In any case,
it should make it into a fixes queue, because this board is currently
broken in 5.10-rc2.
Thanks,
-michael
Am 2020-11-09 11:46, schrieb Vladimir Oltean:
> On Sun, Nov 08, 2020 at 07:00:46PM +0100, Michael Walle wrote:
>> Hi,
>>
>> Am 2020-11-01 14:19, schrieb Michael Walle:
>> > Since commit 71b77a7a27a3 ("enetc: Migrate to PHYLINK and PCS_LYNX") the
>> > network port of the Kontron sl28 board is broken. After the migration to
>> > phylink the device tree has to specify the in-band-mode property. Add
>> > it.
>> >
>> > Fixes: 71b77a7a27a3 ("enetc: Migrate to PHYLINK and PCS_LYNX")
>> > Suggested-by: Vladimir Oltean <[email protected]>
>> > Signed-off-by: Michael Walle <[email protected]>
>>
>> Ping. will this go through the net queue or Shawn's queue. In any
>> case,
>> it should make it into a fixes queue, because this board is currently
>> broken in 5.10-rc2.
>
> Michael, this cannot go through the net queue, since you didn't copy
> [email protected] to the email. It's not in Jakub's patchwork. My
> advice would be to resend it.
Oh damn. Thanks!
-michael
On Sun, Nov 08, 2020 at 07:00:46PM +0100, Michael Walle wrote:
> Hi,
>
> Am 2020-11-01 14:19, schrieb Michael Walle:
> > Since commit 71b77a7a27a3 ("enetc: Migrate to PHYLINK and PCS_LYNX") the
> > network port of the Kontron sl28 board is broken. After the migration to
> > phylink the device tree has to specify the in-band-mode property. Add
> > it.
> >
> > Fixes: 71b77a7a27a3 ("enetc: Migrate to PHYLINK and PCS_LYNX")
> > Suggested-by: Vladimir Oltean <[email protected]>
> > Signed-off-by: Michael Walle <[email protected]>
>
> Ping. will this go through the net queue or Shawn's queue. In any case,
> it should make it into a fixes queue, because this board is currently
> broken in 5.10-rc2.
Michael, this cannot go through the net queue, since you didn't copy
[email protected] to the email. It's not in Jakub's patchwork. My
advice would be to resend it.