2004-10-12 11:38:57

by Raj

[permalink] [raw]
Subject: Build problems with APM/Subarch type

I have been trying to build a 2.6.9-rc4. My box is an Intel P4.

Did all the configuration properly, except that i fumbled on the keyboard and
the option 'Subarchitecture Type' somehow got set to
'(SGI 320/540 Visual Workstation)'.

The build failed with an error 'Undefined reference to machine_real_restart'

It seems that , unless Subarch is PC-Compatible ( CONFIG_PC ) ,
CONFIG_X86_BIOS_REBOOT will not be set and thusly, reboot.c would not be
compiled.

( yeah, i know messing around with configs is suicidal, but.... )

Can this be fixed ?? At the very least, hide APM options #if !(CONFIG_PC) ??
--
######
raj
######


2004-10-13 05:14:52

by Randy.Dunlap

[permalink] [raw]
Subject: Re: Build problems with APM/Subarch type

Raj wrote:
> I have been trying to build a 2.6.9-rc4. My box is an Intel P4.
>
> Did all the configuration properly, except that i fumbled on the keyboard and
> the option 'Subarchitecture Type' somehow got set to
> '(SGI 320/540 Visual Workstation)'.

Using an editor or make *config? which *config?

> The build failed with an error 'Undefined reference to machine_real_restart'

Yep, I see that also.

> It seems that , unless Subarch is PC-Compatible ( CONFIG_PC ) ,
> CONFIG_X86_BIOS_REBOOT will not be set and thusly, reboot.c would not be
> compiled.
>
> ( yeah, i know messing around with configs is suicidal, but.... )
>
> Can this be fixed ?? At the very least, hide APM options #if !(CONFIG_PC) ??

Do you/we/maintainer know that APM is not applicable to all of the
other PC sub-arches?

I agree that it should be fixed, one way or another.
--
~Randy

2004-10-13 05:21:49

by Ricky lloyd

[permalink] [raw]
Subject: Re: Build problems with APM/Subarch type

> > Did all the configuration properly, except that i fumbled on the keyboard and
> > the option 'Subarchitecture Type' somehow got set to
> > '(SGI 320/540 Visual Workstation)'.
>
> Using an editor or make *config? which *config?

make menuconfig.

>
> > The build failed with an error 'Undefined reference to machine_real_restart'
>
> Yep, I see that also.
>
> > It seems that , unless Subarch is PC-Compatible ( CONFIG_PC ) ,
> > CONFIG_X86_BIOS_REBOOT will not be set and thusly, reboot.c would not be
> > compiled.
> >
> > ( yeah, i know messing around with configs is suicidal, but.... )
> >
> > Can this be fixed ?? At the very least, hide APM options #if !(CONFIG_PC) ??
>
> Do you/we/maintainer know that APM is not applicable to all of the
> other PC sub-arches?
>
afaics, i found 'apm.c' only in arch/i386/kernel and arch/arm/kernel.
does that really
confirm that apm would not be applicable for other archs ??

> I agree that it should be fixed, one way or another.
> --
> ~Randy
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>


--
-> Ricky

2004-10-13 05:25:01

by Randy.Dunlap

[permalink] [raw]
Subject: Re: Build problems with APM/Subarch type

Ricky lloyd wrote:
>>>Did all the configuration properly, except that i fumbled on the keyboard and
>>>the option 'Subarchitecture Type' somehow got set to
>>>'(SGI 320/540 Visual Workstation)'.
>>
>>Using an editor or make *config? which *config?
>
>
> make menuconfig.
>
>
>>>The build failed with an error 'Undefined reference to machine_real_restart'
>>
>>Yep, I see that also.
>>
>>
>>>It seems that , unless Subarch is PC-Compatible ( CONFIG_PC ) ,
>>>CONFIG_X86_BIOS_REBOOT will not be set and thusly, reboot.c would not be
>>>compiled.
>>>
>>>( yeah, i know messing around with configs is suicidal, but.... )
>>>
>>>Can this be fixed ?? At the very least, hide APM options #if !(CONFIG_PC) ??
>>
>>Do you/we/maintainer know that APM is not applicable to all of the
>>other PC sub-arches?
>>
>
> afaics, i found 'apm.c' only in arch/i386/kernel and arch/arm/kernel.
> does that really
> confirm that apm would not be applicable for other archs ??

The question is actually about other PC sub-arches, not other (Big)
arch-es.

>
>>I agree that it should be fixed, one way or another.
>>--


--
~Randy

2004-10-13 05:27:12

by Raj

[permalink] [raw]
Subject: Re: Build problems with APM/Subarch type

> Using an editor or make *config? which *config?
>
xconfig

> > The build failed with an error 'Undefined reference to machine_real_restart'
>
> Yep, I see that also.
>
> > It seems that , unless Subarch is PC-Compatible ( CONFIG_PC ) ,
> > CONFIG_X86_BIOS_REBOOT will not be set and thusly, reboot.c would not be
> > compiled.
> >
> > ( yeah, i know messing around with configs is suicidal, but.... )
> >
> > Can this be fixed ?? At the very least, hide APM options #if !(CONFIG_PC) ??
>
> Do you/we/maintainer know that APM is not applicable to all of the
> other PC sub-arches?
>
> I agree that it should be fixed, one way or another.

i am not aware much about the apm dependencies. maintainers might answer
this more correctly.

--
######
raj
######

2004-10-13 05:30:27

by Randy.Dunlap

[permalink] [raw]
Subject: Re: Build problems with APM/Subarch type

Raj wrote:
>>Using an editor or make *config? which *config?
>>
>
> xconfig
>
>
>>>The build failed with an error 'Undefined reference to machine_real_restart'
>>
>>Yep, I see that also.
>>
>>
>>>It seems that , unless Subarch is PC-Compatible ( CONFIG_PC ) ,
>>>CONFIG_X86_BIOS_REBOOT will not be set and thusly, reboot.c would not be
>>>compiled.
>>>
>>>( yeah, i know messing around with configs is suicidal, but.... )
>>>
>>>Can this be fixed ?? At the very least, hide APM options #if !(CONFIG_PC) ??
>>
>>Do you/we/maintainer know that APM is not applicable to all of the
>>other PC sub-arches?
>>
>>I agree that it should be fixed, one way or another.
>
>
> i am not aware much about the apm dependencies. maintainers might answer
> this more correctly.

True. I should have copied Andrey on it earlier.

Andrey, any thoughts about how to keep VISWS from building APM
support? use Kconfig? or does VISWS support APM?

--
~Randy

2004-10-14 09:16:24

by Andrey Panin

[permalink] [raw]
Subject: Re: Build problems with APM/Subarch type

> Raj wrote:
>>>Using an editor or make *config? which *config?
>>>
>>
>> xconfig
>>
>>
>>>>The build failed with an error 'Undefined reference to
>>>> machine_real_restart'
>>>
>>>Yep, I see that also.
>>>
>>>
>>>>It seems that , unless Subarch is PC-Compatible ( CONFIG_PC ) ,
>>>>CONFIG_X86_BIOS_REBOOT will not be set and thusly, reboot.c would not
>>>> be
>>>>compiled.
>>>>
>>>>( yeah, i know messing around with configs is suicidal, but.... )
>>>>
>>>>Can this be fixed ?? At the very least, hide APM options #if
>>>> !(CONFIG_PC) ??
>>>
>>>Do you/we/maintainer know that APM is not applicable to all of the
>>>other PC sub-arches?
>>>
>>>I agree that it should be fixed, one way or another.
>>
>>
>> i am not aware much about the apm dependencies. maintainers might answer
>> this more correctly.
>
> True. I should have copied Andrey on it earlier.
>
> Andrey, any thoughts about how to keep VISWS from building APM
> support? use Kconfig? or does VISWS support APM?

IMHO Kconfig is the best choise. VISWS has no PC compatible BIOS at all,
it uses ARC compilant firmware for startup and configuration. Even though
this firmware does limited BIOS emulation for running ROMs on PCI cards, i
dont think it has working APM BIOS implementation.


2004-10-14 22:51:00

by Randy.Dunlap

[permalink] [raw]
Subject: [PATCH] VISWS: disable APM

(full email thread here:
http://marc.theaimsgroup.com/?t=109758139300007&r=1&w=2
)

Andrey Panin wrote:
>>Raj wrote:
>>
>>>>>The build failed with an error 'Undefined reference to
>>>>>machine_real_restart'
>>>>
>>>>Yep, I see that also.
>>>>
>>>>>Can this be fixed ?? At the very least, hide APM options #if
>>>>>!(CONFIG_PC) ??
>>>>
>>>i am not aware much about the apm dependencies. maintainers might answer
>>>this more correctly.
>>
>>True. I should have copied Andrey on it earlier.
>>
>>Andrey, any thoughts about how to keep VISWS from building APM
>>support? use Kconfig? or does VISWS support APM?
>
> IMHO Kconfig is the best choise. VISWS has no PC compatible BIOS at all,
> it uses ARC compilant firmware for startup and configuration. Even though
> this firmware does limited BIOS emulation for running ROMs on PCI cards, i
> dont think it has working APM BIOS implementation.

Raj, can you test this patch? It WorksForMe.

It disables APM & P4THERMAL support for X86_VISWS so that VISWS
builds correctly.

--
~Randy


Attachments:
visws_noapm.patch (1.04 kB)