2022-09-29 19:51:19

by Dmitry Torokhov

Subject: [PATCH] RM: dts: stihxxx-b2120: fix polarity of reset line of tsin0 port

According to c8sectpfe driver code we first drive reset line low and
then high to reset the port, therefore the reset line is supposed to
be annotated as "active low". This will be important when we convert
the driver to gpiod API.

Signed-off-by: Dmitry Torokhov <[email protected]>
---
arch/arm/boot/dts/stihxxx-b2120.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/stihxxx-b2120.dtsi b/arch/arm/boot/dts/stihxxx-b2120.dtsi
index 2aa94605d3d4..d52a7aaa1074 100644
--- a/arch/arm/boot/dts/stihxxx-b2120.dtsi
+++ b/arch/arm/boot/dts/stihxxx-b2120.dtsi
@@ -178,7 +178,7 @@ tsin0: port {
tsin-num = <0>;
serial-not-parallel;
i2c-bus = <&ssc2>;
- reset-gpios = <&pio15 4 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&pio15 4 GPIO_ACTIVE_LOW>;
dvb-card = <STV0367_TDA18212_NIMA_1>;
};
};
--
2.38.0.rc1.362.ged0d419d3c-goog


--
Dmitry

2022-09-30 07:28:00

by Patrice CHOTARD

Subject: Re: [PATCH] RM: dts: stihxxx-b2120: fix polarity of reset line of tsin0 port

Hi Dmitry

On 9/29/22 21:13, Dmitry Torokhov wrote:
> According to c8sectpfe driver code we first drive reset line low and
> then high to reset the port, therefore the reset line is supposed to
> be annotated as "active low". This will be important when we convert
> the driver to gpiod API.
>
> Signed-off-by: Dmitry Torokhov <[email protected]>
> ---
> arch/arm/boot/dts/stihxxx-b2120.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/stihxxx-b2120.dtsi b/arch/arm/boot/dts/stihxxx-b2120.dtsi
> index 2aa94605d3d4..d52a7aaa1074 100644
> --- a/arch/arm/boot/dts/stihxxx-b2120.dtsi
> +++ b/arch/arm/boot/dts/stihxxx-b2120.dtsi
> @@ -178,7 +178,7 @@ tsin0: port {
> tsin-num = <0>;
> serial-not-parallel;
> i2c-bus = <&ssc2>;
> - reset-gpios = <&pio15 4 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&pio15 4 GPIO_ACTIVE_LOW>;
> dvb-card = <STV0367_TDA18212_NIMA_1>;
> };
> };
Reviewed-by: Patrice Chotard <[email protected]>

Thanks
Patrice

2022-09-30 11:35:05

by Krzysztof Kozlowski

Subject: Re: [PATCH] RM: dts: stihxxx-b2120: fix polarity of reset line of tsin0 port

On 29/09/2022 21:13, Dmitry Torokhov wrote:
> According to c8sectpfe driver code we first drive reset line low and
> then high to reset the port, therefore the reset line is supposed to
> be annotated as "active low". This will be important when we convert
> the driver to gpiod API.
>
> Signed-off-by: Dmitry Torokhov <[email protected]>

Typo in subject - s/RM/ARM/

Best regards,
Krzysztof