2024-03-28 16:05:49

by Oleksij Rempel

[permalink] [raw]
Subject: [PATCH net-next v1 7/9] net: dsa: microchip: enable ETS support for KSZ989X variants

I tested ETS support on KSZ9893, so it should work other KSZ989X
variants too.

Signed-off-by: Oleksij Rempel <[email protected]>
---
drivers/net/dsa/microchip/ksz_common.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c
index ea2d6f8d381bc..08426f85f7707 100644
--- a/drivers/net/dsa/microchip/ksz_common.c
+++ b/drivers/net/dsa/microchip/ksz_common.c
@@ -1378,6 +1378,7 @@ const struct ksz_chip_data ksz_switch_chips[] = {
.port_nirqs = 2,
.num_tx_queues = 4,
.max_ipvs = 8,
+ .tc_ets_supported = true,
.ops = &ksz9477_dev_ops,
.mib_names = ksz9477_mib_names,
.mib_cnt = ARRAY_SIZE(ksz9477_mib_names),
@@ -1411,6 +1412,7 @@ const struct ksz_chip_data ksz_switch_chips[] = {
.port_nirqs = 2,
.num_tx_queues = 4,
.max_ipvs = 8,
+ .tc_ets_supported = true,
.ops = &ksz9477_dev_ops,
.mib_names = ksz9477_mib_names,
.mib_cnt = ARRAY_SIZE(ksz9477_mib_names),
@@ -1442,6 +1444,7 @@ const struct ksz_chip_data ksz_switch_chips[] = {
.port_nirqs = 2,
.num_tx_queues = 4,
.max_ipvs = 8,
+ .tc_ets_supported = true,
.ops = &ksz9477_dev_ops,
.mib_names = ksz9477_mib_names,
.mib_cnt = ARRAY_SIZE(ksz9477_mib_names),
--
2.39.2



2024-04-02 03:39:38

by Arun Ramadoss

[permalink] [raw]
Subject: Re: [PATCH net-next v1 7/9] net: dsa: microchip: enable ETS support for KSZ989X variants

Hi Oleksij,


On Thu, 2024-03-28 at 17:05 +0100, Oleksij Rempel wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
>
> I tested ETS support on KSZ9893, so it should work other KSZ989X
> variants too.

You have enabled ETS for KSZ9897, KSZ9896, KSZ9893. There are other
switches similar to KSZ9893,

KSZ9563 - Same as KSZ9893 but with PTP capability
KSZ8563 - Same as KSZ9563 but without gigabit
KSZ9567 - Same as KSZ9897 but with PTP capability
KSZ8567 - Same as KSZ9567 but without gigabit

Do we need enable ETS for those switches also.


2024-04-02 07:09:06

by Oleksij Rempel

[permalink] [raw]
Subject: Re: [PATCH net-next v1 7/9] net: dsa: microchip: enable ETS support for KSZ989X variants

Hi Arun,

On Tue, Apr 02, 2024 at 03:38:33AM +0000, [email protected] wrote:
> Hi Oleksij,
>
>
> On Thu, 2024-03-28 at 17:05 +0100, Oleksij Rempel wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you
> > know the content is safe
> >
> > I tested ETS support on KSZ9893, so it should work other KSZ989X
> > variants too.
>
> You have enabled ETS for KSZ9897, KSZ9896, KSZ9893. There are other
> switches similar to KSZ9893,
>
> KSZ9563 - Same as KSZ9893 but with PTP capability
> KSZ8563 - Same as KSZ9563 but without gigabit
> KSZ9567 - Same as KSZ9897 but with PTP capability
> KSZ8567 - Same as KSZ9567 but without gigabit
>
> Do we need enable ETS for those switches also.

No, this variants are already enabled.

Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |