Subject: [PATCH] tracing/timer: Add missing hrtimer modes to decode_hrtimer_mode().

The trace output for the HRTIMER_MODE_.*_HARD modes is seen as a number
since these modes are not decoded. The author was not aware of the fancy
decoding function which makes the life easier.

Extend decode_hrtimer_mode() with the additional HRTIMER_MODE_.*_HARD
modes.

Fixes: ae6683d815895 ("hrtimer: Introduce HARD expiry mode")
Signed-off-by: Sebastian Andrzej Siewior <[email protected]>
---
include/trace/events/timer.h | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/include/trace/events/timer.h b/include/trace/events/timer.h
index 2e713a7d9aa3a..5d43751a766c6 100644
--- a/include/trace/events/timer.h
+++ b/include/trace/events/timer.h
@@ -158,7 +158,11 @@ DEFINE_EVENT(timer_class, timer_cancel,
{ HRTIMER_MODE_ABS_SOFT, "ABS|SOFT" }, \
{ HRTIMER_MODE_REL_SOFT, "REL|SOFT" }, \
{ HRTIMER_MODE_ABS_PINNED_SOFT, "ABS|PINNED|SOFT" }, \
- { HRTIMER_MODE_REL_PINNED_SOFT, "REL|PINNED|SOFT" })
+ { HRTIMER_MODE_REL_PINNED_SOFT, "REL|PINNED|SOFT" }, \
+ { HRTIMER_MODE_ABS_HARD, "ABS|HARD" }, \
+ { HRTIMER_MODE_REL_HARD, "REL|HARD" }, \
+ { HRTIMER_MODE_ABS_PINNED_HARD, "ABS|PINNED|HARD" }, \
+ { HRTIMER_MODE_REL_PINNED_HARD, "REL|PINNED|HARD" })

/**
* hrtimer_init - called when the hrtimer is initialized
--
2.40.0


2023-04-18 15:32:37

by Mukesh Ojha

[permalink] [raw]
Subject: Re: [PATCH] tracing/timer: Add missing hrtimer modes to decode_hrtimer_mode().



On 4/18/2023 8:08 PM, Sebastian Andrzej Siewior wrote:
> The trace output for the HRTIMER_MODE_.*_HARD modes is seen as a number
> since these modes are not decoded. The author was not aware of the fancy
> decoding function which makes the life easier.
>
> Extend decode_hrtimer_mode() with the additional HRTIMER_MODE_.*_HARD
> modes.
>
> Fixes: ae6683d815895 ("hrtimer: Introduce HARD expiry mode")
> Signed-off-by: Sebastian Andrzej Siewior <[email protected]>

Good catch.
Reviewed-by: Mukesh Ojha <[email protected]>

-Mukesh

> ---
> include/trace/events/timer.h | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/include/trace/events/timer.h b/include/trace/events/timer.h
> index 2e713a7d9aa3a..5d43751a766c6 100644
> --- a/include/trace/events/timer.h
> +++ b/include/trace/events/timer.h
> @@ -158,7 +158,11 @@ DEFINE_EVENT(timer_class, timer_cancel,
> { HRTIMER_MODE_ABS_SOFT, "ABS|SOFT" }, \
> { HRTIMER_MODE_REL_SOFT, "REL|SOFT" }, \
> { HRTIMER_MODE_ABS_PINNED_SOFT, "ABS|PINNED|SOFT" }, \
> - { HRTIMER_MODE_REL_PINNED_SOFT, "REL|PINNED|SOFT" })
> + { HRTIMER_MODE_REL_PINNED_SOFT, "REL|PINNED|SOFT" }, \
> + { HRTIMER_MODE_ABS_HARD, "ABS|HARD" }, \
> + { HRTIMER_MODE_REL_HARD, "REL|HARD" }, \
> + { HRTIMER_MODE_ABS_PINNED_HARD, "ABS|PINNED|HARD" }, \
> + { HRTIMER_MODE_REL_PINNED_HARD, "REL|PINNED|HARD" })
>
> /**
> * hrtimer_init - called when the hrtimer is initialized

2023-04-24 21:46:16

by Steven Rostedt

[permalink] [raw]
Subject: Re: [PATCH] tracing/timer: Add missing hrtimer modes to decode_hrtimer_mode().

On Tue, 18 Apr 2023 16:38:54 +0200
Sebastian Andrzej Siewior <[email protected]> wrote:

> The trace output for the HRTIMER_MODE_.*_HARD modes is seen as a number
> since these modes are not decoded. The author was not aware of the fancy
> decoding function which makes the life easier.
>
> Extend decode_hrtimer_mode() with the additional HRTIMER_MODE_.*_HARD
> modes.
>
> Fixes: ae6683d815895 ("hrtimer: Introduce HARD expiry mode")
> Signed-off-by: Sebastian Andrzej Siewior <[email protected]>

Acked-by: Steven Rostedt (Google) <[email protected]>

-- Steve

Subject: Re: [PATCH] tracing/timer: Add missing hrtimer modes to decode_hrtimer_mode().

On 2023-04-24 17:44:41 [-0400], Steven Rostedt wrote:
> On Tue, 18 Apr 2023 16:38:54 +0200
> Sebastian Andrzej Siewior <[email protected]> wrote:
>
> > The trace output for the HRTIMER_MODE_.*_HARD modes is seen as a number
> > since these modes are not decoded. The author was not aware of the fancy
> > decoding function which makes the life easier.
> >
> > Extend decode_hrtimer_mode() with the additional HRTIMER_MODE_.*_HARD
> > modes.
> >
> > Fixes: ae6683d815895 ("hrtimer: Introduce HARD expiry mode")
> > Signed-off-by: Sebastian Andrzej Siewior <[email protected]>
>
> Acked-by: Steven Rostedt (Google) <[email protected]>

Could this be either routed via the tracing tree or the tip tree but
please route this :)

Sebastian

2023-05-25 01:18:23

by Steven Rostedt

[permalink] [raw]
Subject: Re: [PATCH] tracing/timer: Add missing hrtimer modes to decode_hrtimer_mode().

On Wed, 24 May 2023 17:39:28 +0200
Sebastian Andrzej Siewior <[email protected]> wrote:

> On 2023-04-24 17:44:41 [-0400], Steven Rostedt wrote:
> > On Tue, 18 Apr 2023 16:38:54 +0200
> > Sebastian Andrzej Siewior <[email protected]> wrote:
> >
> > > The trace output for the HRTIMER_MODE_.*_HARD modes is seen as a number
> > > since these modes are not decoded. The author was not aware of the fancy
> > > decoding function which makes the life easier.
> > >
> > > Extend decode_hrtimer_mode() with the additional HRTIMER_MODE_.*_HARD
> > > modes.
> > >
> > > Fixes: ae6683d815895 ("hrtimer: Introduce HARD expiry mode")
> > > Signed-off-by: Sebastian Andrzej Siewior <[email protected]>
> >
> > Acked-by: Steven Rostedt (Google) <[email protected]>
>
> Could this be either routed via the tracing tree or the tip tree but
> please route this :)
>

Events are normally owned by the subsystem they are used in. So it
should go through tip. But if I get an ack from the subsystem
maintainer, I can route it through tracing.

-- Steve

2023-06-09 20:19:52

by Steven Rostedt

[permalink] [raw]
Subject: Re: [PATCH] tracing/timer: Add missing hrtimer modes to decode_hrtimer_mode().

On Wed, 24 May 2023 20:25:26 -0400
Steven Rostedt <[email protected]> wrote:

> Events are normally owned by the subsystem they are used in. So it
> should go through tip. But if I get an ack from the subsystem
> maintainer, I can route it through tracing.

Thomas, care to give me an ack? Or do you want to take it?

-- Steve

Subject: [tip: timers/core] tracing/timer: Add missing hrtimer modes to decode_hrtimer_mode().

The following commit has been merged into the timers/core branch of tip:

Commit-ID: 2951580ba6adb082bb6b7154a5ecb24e7c1f7569
Gitweb: https://git.kernel.org/tip/2951580ba6adb082bb6b7154a5ecb24e7c1f7569
Author: Sebastian Andrzej Siewior <[email protected]>
AuthorDate: Tue, 18 Apr 2023 16:38:54 +02:00
Committer: Thomas Gleixner <[email protected]>
CommitterDate: Mon, 19 Jun 2023 09:09:14 +02:00

tracing/timer: Add missing hrtimer modes to decode_hrtimer_mode().

The trace output for the HRTIMER_MODE_.*_HARD modes is seen as a number
since these modes are not decoded. The author was not aware of the fancy
decoding function which makes the life easier.

Extend decode_hrtimer_mode() with the additional HRTIMER_MODE_.*_HARD
modes.

Fixes: ae6683d815895 ("hrtimer: Introduce HARD expiry mode")
Signed-off-by: Sebastian Andrzej Siewior <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Reviewed-by: Mukesh Ojha <[email protected]>
Acked-by: Steven Rostedt (Google) <[email protected]>
Link: https://lore.kernel.org/r/[email protected]

---
include/trace/events/timer.h | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/include/trace/events/timer.h b/include/trace/events/timer.h
index 3e8619c..b4bc282 100644
--- a/include/trace/events/timer.h
+++ b/include/trace/events/timer.h
@@ -158,7 +158,11 @@ DEFINE_EVENT(timer_class, timer_cancel,
{ HRTIMER_MODE_ABS_SOFT, "ABS|SOFT" }, \
{ HRTIMER_MODE_REL_SOFT, "REL|SOFT" }, \
{ HRTIMER_MODE_ABS_PINNED_SOFT, "ABS|PINNED|SOFT" }, \
- { HRTIMER_MODE_REL_PINNED_SOFT, "REL|PINNED|SOFT" })
+ { HRTIMER_MODE_REL_PINNED_SOFT, "REL|PINNED|SOFT" }, \
+ { HRTIMER_MODE_ABS_HARD, "ABS|HARD" }, \
+ { HRTIMER_MODE_REL_HARD, "REL|HARD" }, \
+ { HRTIMER_MODE_ABS_PINNED_HARD, "ABS|PINNED|HARD" }, \
+ { HRTIMER_MODE_REL_PINNED_HARD, "REL|PINNED|HARD" })

/**
* hrtimer_init - called when the hrtimer is initialized