2024-02-04 22:39:52

by Ricardo B. Marliere

[permalink] [raw]
Subject: [PATCH] const_structs.checkpatch: add bus_type

Since commit d492cc2573a0 ("driver core: device.h: make struct bus_type
a const *"), the driver core can properly handle constant struct
bus_type. Make sure that new usages of the struct already enter the tree
as const.

Suggested-by: Thomas Weißschuh <[email protected]>
Signed-off-by: Ricardo B. Marliere <[email protected]>
---
scripts/const_structs.checkpatch | 1 +
1 file changed, 1 insertion(+)

diff --git a/scripts/const_structs.checkpatch b/scripts/const_structs.checkpatch
index 188412aa2757..7427313adc7a 100644
--- a/scripts/const_structs.checkpatch
+++ b/scripts/const_structs.checkpatch
@@ -2,6 +2,7 @@ acpi_dock_ops
address_space_operations
backlight_ops
block_device_operations
+bus_type
clk_ops
comedi_lrange
component_ops

---
base-commit: 41b9fb381a486360b2daaec0c7480f8e3ff72bc7
change-id: 20240204-bus_cleanup-checkpatch-719a62209250

Best regards,
--
Ricardo B. Marliere <[email protected]>



2024-02-05 12:06:09

by Thomas Weißschuh

[permalink] [raw]
Subject: Re: [PATCH] const_structs.checkpatch: add bus_type

On 2024-02-04 19:39:57-0300, Ricardo B. Marliere wrote:
> Since commit d492cc2573a0 ("driver core: device.h: make struct bus_type
> a const *"), the driver core can properly handle constant struct
> bus_type. Make sure that new usages of the struct already enter the tree
> as const.
>
> Suggested-by: Thomas Weißschuh <[email protected]>
> Signed-off-by: Ricardo B. Marliere <[email protected]>

Reviewed-by: Thomas Weißschuh <[email protected]>

> ---
> scripts/const_structs.checkpatch | 1 +
> 1 file changed, 1 insertion(+)
>

Thanks!

2024-02-05 17:56:05

by Joe Perches

[permalink] [raw]
Subject: Re: [PATCH] const_structs.checkpatch: add bus_type

On Sun, 2024-02-04 at 19:39 -0300, Ricardo B. Marliere wrote:
> Since commit d492cc2573a0 ("driver core: device.h: make struct bus_type
> a const *"), the driver core can properly handle constant struct
> bus_type. Make sure that new usages of the struct already enter the tree
> as const.
>
> Suggested-by: Thomas Wei?schuh <[email protected]>
> Signed-off-by: Ricardo B. Marliere <[email protected]>

Andrew? Can you please pick this up?

> ---
> scripts/const_structs.checkpatch | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/const_structs.checkpatch b/scripts/const_structs.checkpatch
> index 188412aa2757..7427313adc7a 100644
> --- a/scripts/const_structs.checkpatch
> +++ b/scripts/const_structs.checkpatch
> @@ -2,6 +2,7 @@ acpi_dock_ops
> address_space_operations
> backlight_ops
> block_device_operations
> +bus_type
> clk_ops
> comedi_lrange
> component_ops
>
> ---
> base-commit: 41b9fb381a486360b2daaec0c7480f8e3ff72bc7
> change-id: 20240204-bus_cleanup-checkpatch-719a62209250
>
> Best regards,


2024-02-05 19:04:26

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH] const_structs.checkpatch: add bus_type

On Sun, Feb 04, 2024 at 07:39:57PM -0300, Ricardo B. Marliere wrote:
> Since commit d492cc2573a0 ("driver core: device.h: make struct bus_type
> a const *"), the driver core can properly handle constant struct
> bus_type. Make sure that new usages of the struct already enter the tree
> as const.
>
> Suggested-by: Thomas Wei?schuh <[email protected]>
> Signed-off-by: Ricardo B. Marliere <[email protected]>

Note, there are a handful of in-kernel instances where this will not
work, but it's not worth special-casing them, they will be obvious when
attempts to change them happen.

Reviewed-by: Greg Kroah-Hartman <[email protected]>