2024-04-09 09:14:57

by Jim Liu

Subject: [PATCH v1] gpio: nuvoton: Fix sgpio irq handle error

Remove irq_find_mapping and use generic_handle_domain_irq

Signed-off-by: Jim Liu <[email protected]>
---
drivers/gpio/gpio-npcm-sgpio.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/gpio/gpio-npcm-sgpio.c b/drivers/gpio/gpio-npcm-sgpio.c
index d31788b43abc..136838c25756 100644
--- a/drivers/gpio/gpio-npcm-sgpio.c
+++ b/drivers/gpio/gpio-npcm-sgpio.c
@@ -443,11 +443,9 @@ static void npcm_sgpio_irq_handler(struct irq_desc *desc)
const struct npcm_sgpio_bank *bank = &npcm_sgpio_banks[i];

reg = ioread8(bank_reg(gpio, bank, EVENT_STS));
- for_each_set_bit(j, &reg, 8) {
- girq = irq_find_mapping(gc->irq.domain,
- i * 8 + gpio->nout_sgpio + j);
- generic_handle_domain_irq(gc->irq.domain, girq);
- }
+ for_each_set_bit(j, &reg, 8)
+ generic_handle_domain_irq(gc->irq.domain,
+ i * 8 + gpio->nout_sgpio + j);
}

chained_irq_exit(ic, desc);
--
2.25.1

2024-04-09 13:25:33

by Dan Carpenter

Subject: Re: [PATCH v1] gpio: nuvoton: Fix sgpio irq handle error

On Tue, Apr 09, 2024 at 05:14:19PM +0800, Jim Liu wrote:
> Remove irq_find_mapping and use generic_handle_domain_irq
>

The subject says that it's a fix, but the commit message doesn't tell
us what the problem is. And there is no fixes tag.

> Signed-off-by: Jim Liu <[email protected]>

regards,
dan carpenter