In mtk_devapc_probe(), if of_iomap succeeds and any following error occurs,
it needs to deallocate the resource.
Fix this by repalcing of_iomap with devm_platform_ioremap_resource, which
automatically self-manages the resource. This can avoid modifying error
handling code.
Signed-off-by: zhengkang huang <[email protected]>
Reviewed-by: Dongliang Mu <[email protected]>
---
drivers/soc/mediatek/mtk-devapc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/mediatek/mtk-devapc.c b/drivers/soc/mediatek/mtk-devapc.c
index bad139cb117e..bea3ec8ab015 100644
--- a/drivers/soc/mediatek/mtk-devapc.c
+++ b/drivers/soc/mediatek/mtk-devapc.c
@@ -268,7 +268,7 @@ static int mtk_devapc_probe(struct platform_device *pdev)
ctx->data = of_device_get_match_data(&pdev->dev);
ctx->dev = &pdev->dev;
- ctx->infra_base = of_iomap(node, 0);
+ ctx->infra_base = devm_platform_ioremap_resource(pdev, 0);
if (!ctx->infra_base)
return -EINVAL;
--
2.40.0
Il 14/04/23 11:21, zhengkang huang ha scritto:
> In mtk_devapc_probe(), if of_iomap succeeds and any following error occurs,
> it needs to deallocate the resource.
>
> Fix this by repalcing of_iomap with devm_platform_ioremap_resource, which
> automatically self-manages the resource. This can avoid modifying error
> handling code.
>
> Signed-off-by: zhengkang huang <[email protected]>
> Reviewed-by: Dongliang Mu <[email protected]>
You haven't tested this patch on any MediaTek SoC, have you?
This will break devapc.
Regards,
Angelo
On 2023/4/18 18:09, AngeloGioacchino Del Regno wrote:
> Il 14/04/23 11:21, zhengkang huang ha scritto:
>> In mtk_devapc_probe(), if of_iomap succeeds and any following error
>> occurs,
>> it needs to deallocate the resource.
>>
>> Fix this by repalcing of_iomap with devm_platform_ioremap_resource,
>> which
>> automatically self-manages the resource. This can avoid modifying error
>> handling code.
>>
>> Signed-off-by: zhengkang huang <[email protected]>
>> Reviewed-by: Dongliang Mu <[email protected]>
>
> You haven't tested this patch on any MediaTek SoC, have you?
Yes, this issue is found by static analysis and remains untested.
Sorry for the functionablity issue.
Dongliang Mu
>
> This will break devapc.
>
> Regards,
> Angelo
>