2023-07-19 19:40:26

by Tomasz Jeznach

[permalink] [raw]

Subject: [PATCH 02/11] RISC-V: arch/riscv/config: enable RISC-V IOMMU support

---

---
arch/riscv/configs/defconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
index 0a0107460a5c..1a0c3b24329f 100644
--- a/arch/riscv/configs/defconfig
+++ b/arch/riscv/configs/defconfig
@@ -178,6 +178,7 @@ CONFIG_VIRTIO_PCI=y
CONFIG_VIRTIO_BALLOON=y
CONFIG_VIRTIO_INPUT=y
CONFIG_VIRTIO_MMIO=y
+CONFIG_RISCV_IOMMU=y
CONFIG_SUN8I_DE2_CCU=m
CONFIG_SUN50I_IOMMU=y
CONFIG_RPMSG_CHAR=y
--
2.34.1

2023-07-19 20:58:16

by Conor Dooley

[permalink] [raw]

Subject: Re: [PATCH 02/11] RISC-V: arch/riscv/config: enable RISC-V IOMMU support

---

On Wed, Jul 19, 2023 at 12:33:46PM -0700, Tomasz Jeznach wrote:

$subject: RISC-V: arch/riscv/config: enable RISC-V IOMMU support

Please look at any other commits to the files you are touching
and use a subject line that emulates them. In this case, try
git log --oneline --no-merges -- arch/riscv/configs/
Same goes for the odd pattern in your driver patches.

Also, the patch may be trivial, but you still need to sign off on it
and provide a commit message.

Thanks,
Conor.

> ---
> arch/riscv/configs/defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
> index 0a0107460a5c..1a0c3b24329f 100644
> --- a/arch/riscv/configs/defconfig
> +++ b/arch/riscv/configs/defconfig
> @@ -178,6 +178,7 @@ CONFIG_VIRTIO_PCI=y
> CONFIG_VIRTIO_BALLOON=y
> CONFIG_VIRTIO_INPUT=y
> CONFIG_VIRTIO_MMIO=y
> +CONFIG_RISCV_IOMMU=y
> CONFIG_SUN8I_DE2_CCU=m
> CONFIG_SUN50I_IOMMU=y
> CONFIG_RPMSG_CHAR=y
> --
> 2.34.1
>
>
> _______________________________________________
> linux-riscv mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-riscv

---

Attachments:

(No filename) (1.17 kB)
signature.asc (235.00 B)
Download all attachments

2023-07-19 21:52:56

by Tomasz Jeznach

[permalink] [raw]

Subject: Re: [PATCH 02/11] RISC-V: arch/riscv/config: enable RISC-V IOMMU support

---

On Wed, Jul 19, 2023 at 1:22 PM Conor Dooley <[email protected]> wrote:
>
> On Wed, Jul 19, 2023 at 12:33:46PM -0700, Tomasz Jeznach wrote:
>
> $subject: RISC-V: arch/riscv/config: enable RISC-V IOMMU support
>
> Please look at any other commits to the files you are touching
> and use a subject line that emulates them. In this case, try
> git log --oneline --no-merges -- arch/riscv/configs/
> Same goes for the odd pattern in your driver patches.
>
> Also, the patch may be trivial, but you still need to sign off on it
> and provide a commit message.
>

ack. added to-do the list for v2.

Thank you,
- Tomasz

> Thanks,
> Conor.
>
> > ---
> > arch/riscv/configs/defconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
> > index 0a0107460a5c..1a0c3b24329f 100644
> > --- a/arch/riscv/configs/defconfig
> > +++ b/arch/riscv/configs/defconfig
> > @@ -178,6 +178,7 @@ CONFIG_VIRTIO_PCI=y
> > CONFIG_VIRTIO_BALLOON=y
> > CONFIG_VIRTIO_INPUT=y
> > CONFIG_VIRTIO_MMIO=y
> > +CONFIG_RISCV_IOMMU=y
> > CONFIG_SUN8I_DE2_CCU=m
> > CONFIG_SUN50I_IOMMU=y
> > CONFIG_RPMSG_CHAR=y
> > --
> > 2.34.1
> >
> >
> > _______________________________________________
> > linux-riscv mailing list
> > [email protected]
> > http://lists.infradead.org/mailman/listinfo/linux-riscv

2023-07-20 07:01:20

by Krzysztof Kozlowski

[permalink] [raw]

Subject: Re: [PATCH 02/11] RISC-V: arch/riscv/config: enable RISC-V IOMMU support

---

On 19/07/2023 23:07, Tomasz Jeznach wrote:
> On Wed, Jul 19, 2023 at 1:22 PM Conor Dooley <[email protected]> wrote:
>>
>> On Wed, Jul 19, 2023 at 12:33:46PM -0700, Tomasz Jeznach wrote:
>>
>> $subject: RISC-V: arch/riscv/config: enable RISC-V IOMMU support
>>
>> Please look at any other commits to the files you are touching
>> and use a subject line that emulates them. In this case, try
>> git log --oneline --no-merges -- arch/riscv/configs/
>> Same goes for the odd pattern in your driver patches.
>>
>> Also, the patch may be trivial, but you still need to sign off on it
>> and provide a commit message.
>>
>
> ack. added to-do the list for v2.

Please run checkpatch before sending.

Best regards,
Krzysztof